Skip to content

Add reflection APIs to sidebar #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Add reflection APIs to sidebar #229

merged 1 commit into from
Aug 22, 2024

Conversation

samkim
Copy link
Member

@samkim samkim commented May 29, 2024

No description provided.

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 11:15pm

@jzelinskie
Copy link
Member

This doesn't really seem like a "concept" to me.

This doc also doesn't seem to be really adding much beyond API docs, which are already auto-generated and maintained elsewhere.

I think it makes more sense to take the actual meat of the content and create a section in the schema doc about how folks can query the schema with these APIs at runtime.

@josephschorr
Copy link
Member

This doc also doesn't seem to be really adding much beyond API docs, which are already auto-generated and maintained elsewhere.

And often not discoverable, unfortunately.

I think it makes more sense to take the actual meat of the content and create a section in the schema doc about how folks can query the schema with these APIs at runtime.

Schema documentation talks about schema concepts; it is not the right place IMO for API information

@vroldanbet vroldanbet merged commit ae48706 into main Aug 22, 2024
9 checks passed
@vroldanbet vroldanbet deleted the nav-reflection-apis branch August 22, 2024 11:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants