-
Notifications
You must be signed in to change notification settings - Fork 85
Added ErrorContext
to give more context which action caused the actual error.
#1530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks great. I see that you added an additional property to avoid breaking the API. Extending the existing error property would make it easier for usage. Either you have an error object or its null. If you have one you can find the message + details... For me it would be ok in that situation to bump the major version and break the ABI... |
Ideally we also adapt error object within that new component: #1476 |
Sound like a good idea. Also since now |
I've just adjusted as discussed. I've tried to find a sweet spot between do not introduce a new property but also do not break the current API tooo much. Therefore: What was in the initial contribution |
Thanks for contributing! |
Checklist
Details
This added
AuthState.errorContext: ErrorContext
which holds information what was causing the issue. Most likely which method and (if available) the providedargs
.