fix: Ensure JWE expires as expected #2040
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2040 +/- ##
==========================================
+ Coverage 78.47% 78.51% +0.04%
==========================================
Files 21 21
Lines 1909 1918 +9
Branches 307 307
==========================================
+ Hits 1498 1506 +8
- Misses 405 406 +1
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frederikprijck
commented
Apr 7, 2025
| @@ -31,6 +32,7 @@ export async function encrypt( | |||
|
|
|||
| const encryptedCookie = await new jose.EncryptJWT(payload) | |||
| .setProtectedHeader({ enc: ENC, alg: ALG, ...additionalHeaders }) | |||
| .setExpirationTime(expiration) | |||
There was a problem hiding this comment.
This is the main thing this PR is fixing. The rest is just accommodating for this change.
tusharpandey13
previously approved these changes
Apr 7, 2025
frederikprijck
force-pushed
the
fix/jwe-expiration
branch
from
15c227e to
f1e46e6
Compare
frederikprijck
force-pushed
the
fix/jwe-expiration
branch
from
f1e46e6 to
2179d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JWE we use for the cookie was never expiring properly, only the cookie had an expiration configured.
This means that the actual value of the cookie, the JWE, is still valid after the cookie is expired.
This PR ensures the JWE expires, in addition to cookie itself and aligns both expirations.
Adding the expiration to the JWE made alot of the tests fail because all tests had a fixed check on the JWE payload, but we have now added an additional expiration property. Therefore, I have changed the tests to use
expect.objectContaining()