-
Notifications
You must be signed in to change notification settings - Fork 30
upload default share image, remove unnecessary meta tag front matter #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mikemimik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A different approach to a wide change like this, might be to contain it to a single folder and it's sibling translation folders. This way we can validate the change on a small scale, and then introduce many smaller pull-requests all introducing the same change to limit the risk of each pull-request.
@hazel-nut what do you think about decomposing this pull-request into many smaller pull-requests?
d487462 to
20f0380
Compare
|
@mikemimik not an issue if you prefer. i broke up this PR into more granular commits per top-level docs directory to give you an idea of each diff with that approach. if that seems okay to you, i can close this PR and open a dozen or so smaller corresponding ones. |
summary
update the default share image:
og:imagefront matter and set the default share image in the site configremove unnecessary meta tag front matter:
og:titleandtwitter:titleare set fromtitleog:descriptionandtwitter:descriptionare set fromdescriptionog:urlis generated automatically from the canonical URL, which is built from the page URLremove
permalinkfront matter because it doesn't do anything (page URLs are determined by path and filename)testing
permalink, and see that the URL of the page doesn't change