-
Notifications
You must be signed in to change notification settings - Fork 30
Contribution Guide #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Contribution Guide #329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments / suggestions on this file:
- Should we call it
CONTRIBUTING.md(note, not.mdx) and hoist to the root of the project per GitHub conventions / guidance? - Does this apply to both sites (i.e.
auth0andauth0-genai) or just one (i.e.main/(auth0))?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@btiernay this should also apply to auth4genai
| For contributors in the Auth0 organization: | ||
| * Use your Auth0 GitHub account. | ||
| * Review the [Mintlify documentation](https://www.mintlify.com/docs). | ||
| * Review the [READ.ME](main/README.md) to set up your local environment and contribution workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: README
| "enforce_online_refresh_tokens": true | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this continue to subsume the subsequent content / example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
| **Example** | ||
| > 1. Navigate to your application’s settings, [Auth0 Dashboard > Applications > Settings](https://manage.auth0.com/application/settings). | ||
| > | ||
| > <Frame!>[Auth0 Dashboard > Applications > Settings](/relative-link-to-the-image)</Frame> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| > <Frame!>[Auth0 Dashboard > Applications > Settings](/relative-link-to-the-image)</Frame> | |
| > <Frame></Frame> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@btiernay this should also apply to auth4genai
| Auth0 documentation, https://www.auth0.com/docs is located at https://github.com/auth0/docs-v2/. If you are not in the Auth0 organization, report inconsistencies and bugs under the [Issues](https://github.com/auth0/docs-v2/issues) section. | ||
|
|
||
| For contributors in the Auth0 organization: | ||
| * Use your Auth0 GitHub account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think you can use your Auth0 (Atko) GitHub account. you'll need to use your personal GitHub account
| * We do **not** use italics in docs due to issues with screen readers and accessibility. | ||
| * Avoid using underline. We use this for linking and additional underline can clutter the UI. | ||
|
|
||
| To learn about UI elements, such as Notes, Code blocks, Tabs, and Warning labels, review Embedded Content Types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should Embedded Content Types be linked to an article somewhere?
| Do not store images in external locations like Dropbox, CloudUp, or the Auth0 CDN. | ||
| </Warning> | ||
|
|
||
| Auth0 organization members should review the Screenshot policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we link to the screenshot policy here? https://oktawiki.atlassian.net/wiki/spaces/DOCS/pages/2544472521/Screenshot+Use+Policy or an anchor link to the screenshot section below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a Public doc so we should review what the policy / guidance is for linking to internal resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in that case, let's just do the anchor link to the screenshot section then
|
|
||
| ### Components | ||
|
|
||
| We use component in technical documentation to draw attention to important information customers need to know. Review the following components and when best to use them. To learn more, read [Components](https://www.mintlify.com/docs/components). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| We use component in technical documentation to draw attention to important information customers need to know. Review the following components and when best to use them. To learn more, read [Components](https://www.mintlify.com/docs/components). | |
| We use components in technical documentation to draw attention to important information customers need to know. Review the following components and when best to use them. To learn more, read [Components](https://www.mintlify.com/docs/components). |
| "enforce_online_refresh_tokens": true | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
|
||
| ## Reference links | ||
|
|
||
| The Learn More section at the bottom of each page indicates a list of associated articles to read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The Learn More section at the bottom of each page indicates a list of associated articles to read. | |
| The Learn More section at the bottom of each page indicates a list of associated articles to read. |
|
|
||
| ### Borders | ||
|
|
||
| Apply a 1px centered border of color #cccccc to keep the image from blending with the background and appearing to float. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we still planning on doing this when we have Frames now?
|
|
||
| Next, add the relative path to the `{}docs.json` file to add it to the side navigation panel under the appropriate heading: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you pretty print this json :)
btiernay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 82: Incomplete sentence
2. Scroll down the
This sentence is cut off mid-thought. Please complete it or remove the incomplete example.
| <Note> | ||
| Try to keep sub-bullets even. If you have an A, try to also have a B. | ||
| </Note> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: should be "asterisks" instead of "astricks"
| 3. For existing words, find the short text you will need for the tooltip. You can search for the term with the `term=` tag. | ||
|
|
||
| <Note> | ||
| Use the same short description to maintain consistency across Auth0 documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be helpful to add language tags to code blocks for syntax highlighting. Examples:
- Line 277:
glossary.jsxcould usejavascript - Line 305: osascript command could use
bash - Line 345:
docs.jsoncould usejson
| ``` | ||
| osascript -e 'tell application "Chrome" to set the bounds of the front window to {100, 150, 1200, 900}' | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The osascript command only works on macOS. Could add a note for cross-platform compatibility:
> **Note**: This script is macOS-specific. Windows and Linux users should manually resize their browser window to 1100x750px.Or alternatively, could document using browser DevTools responsive design mode as a cross-platform option.
| | `configure-identity-provider.mdx` | `ConfigureIdentityProviders.mdx` | | ||
| | `customize-ul-templates.mdx` | `customize_ul_templates.mdx` | | ||
|
|
||
| ### File headings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mintlify and most MDX documentation typically refers to this as "frontmatter" or "metadata" rather than "File headings". Might be clearer to use the more common term.
| 2. Choose the application to update. | ||
| 3. Scroll to the **Cross-Origin Authentication** setting. | ||
|
|
||
| Sub-level steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using <p></p> tags for spacing here - Mintlify usually handles spacing with blank lines. Might be simpler to use standard Markdown formatting with blank lines between sub-steps.
| * Include any default values, minimum and maximum values, and/or recommended values. | ||
| * Use monospaced font (code font) for parameter, field, or property. | ||
| * Descriptions should be in regular text with the exception of other properties, fields, or parameters. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space before the asterisks here - should just be **Markdown tables**
| <tr> | ||
| <th><strong>Parameter</strong></th> | ||
| <th><strong>Description</strong></th> | ||
| </tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <Note> here looks like it might be part of the HTML table example. Could move it outside the code block to make it clearer it's separate guidance about when to use Markdown vs HTML tables.
📝 Before you begin
By opening this PR, you agree to the terms of the Auth0 Code of Conduct. For guidance on creating a high-quality PR, see the Contributing Guidelines.
✏️ Changes
Adding the Contribution Guide. This Guide is going to be part of the PR Template in draft by @btiernay.
main/documentation site📁 Documentation scope
Docs site(s) affected
main/auth4genai/Other areas
ui/).github/workflows/)tools/)Type of change
.github/workflows/)tools/)Paths:
main/CONTRIBUTION.mdx🔗 References
Related PRs:
🎯 Testing
Local validation
mint devin affected foldersmint broken-links(when applicable)mint a11y(when applicable)npm run buildinui/(for UI changes)Style and structure
Repo checks
🔄 Redirects
Not applicable - no URL changes.
🌍 Internationalization (main docs only)
🧩 Impact and dependencies
User-facing impact
Dependencies
🚀 Deployment
📝 Follow-up
💬 Additional context
This contribution guide includes comprehensive documentation for Auth0 Staff contributors covering:
og:description,og:title,permalink,sidebarTitle, etc.The guide ensures consistency and quality across all documentation contributions.
Tip
Useful references: