Skip to content

feat: allow optional customization of cbor encode/decode options#52

Closed
warren-gallagher wants to merge 2 commits into
auth0-lab:mainfrom
AffinitiQuest:allow-control-over-default-cbor-encode-decode-options
Closed

feat: allow optional customization of cbor encode/decode options#52
warren-gallagher wants to merge 2 commits into
auth0-lab:mainfrom
AffinitiQuest:allow-control-over-default-cbor-encode-decode-options

Conversation

@warren-gallagher
Copy link
Copy Markdown

Add new functions to src/cbor/index that allow getting and setting of default cbor encode/decode options.

Enhance cbor tests to demonstrate successful use in how maps get encoded.

Addresses issue auth0-lab/mdl/issues/48

Add new functions to src/cbor/index that allow getting and setting of
default cbor encode/decode options.

Enhance cbor tests to demonstrate successful use in how maps get encoded.
@siacomuzzi
Copy link
Copy Markdown
Contributor

LGTM
Minor: shouldn't you also expose it by exporting it in src/index.ts?

@siacomuzzi
Copy link
Copy Markdown
Contributor

Thanks for contributing!

Commits must have verified signatures

I'm unable to remove this restriction, so I'll create a new PR to meet this requirement.

@siacomuzzi
Copy link
Copy Markdown
Contributor

see #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants