fix(WithAuth): options.authRequired can default to undefined#9
Open
chrislambe wants to merge 1 commit into
Open
fix(WithAuth): options.authRequired can default to undefined#9chrislambe wants to merge 1 commit into
options.authRequired can default to undefined#9chrislambe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
options.authRequiredcheck inonRequestis causing unexpected behavior. The docs say thatauthRequireddefaults totrue. However the wayWithAuthis written, if an empty options object or an options object with onlydebugis provided,authRequireddefaults toundefined.This wouldn't be a problem because the local
authRequiredis set totrueifoptions.authRequiredis nullish, butonRequestchecksoptions.authRequiredinstead ofauthRequired. For me this was causingonAuthenticatedRequestnot to fire even though my request was providing an access token.This PR changes
onRequestto use the localauthRequired. It also sets theoptionsdefault value to{}instead of{ authRequired: true }in an effort to prevent similar bugs in the future. Setting{ authRequired: true }as the default value foroptionscan only lead to confusion since the logic insideWithAuthshould be using the localauthRequiredanyways.