Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify make actions #518

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

simplify make actions #518

wants to merge 13 commits into from

Conversation

dmah42
Copy link
Contributor

@dmah42 dmah42 commented Jun 28, 2024

No description provided.

@dmah42
Copy link
Contributor Author

dmah42 commented Jul 5, 2024

pr check is, ironically, failing. i'll need to figure out which tests are a problem first before submitting this as i want a cleaner Makefile but not at the expense of an all-in-one PR check workflow.

@dmah42
Copy link
Contributor Author

dmah42 commented Jul 8, 2024

do we need make prcheck?

the Tester actions today run make <project>-test which runs cargo test on the project (and builds/lints auraed)

prcheck builds and lints all the projects and runs test-all, which includes "ignored" tests.

maybe what we need is:

  1. Tester workflows that run -lint and -test per project
  2. non-required -test-all workflow that is maintained as best-effort.

wdyt?

@dmah42
Copy link
Contributor Author

dmah42 commented Jul 8, 2024

looks like some youki/dependency issue in the 10x builders.

@dmah42
Copy link
Contributor Author

dmah42 commented Jul 8, 2024

"thread 'cells_list_must_list_allocated_cells_recursively' panicked at auraed/tests/common/mod.rs:93:6:
failed to create client: Other(Failed to read server root CA certificate from path '/etc/aurae/pki/ca.crt'"

looks solvable, but maybe not as part of this PR?

@dmah42 dmah42 marked this pull request as ready for review July 8, 2024 15:47
@mccormickt
Copy link
Contributor

mccormickt commented Jul 15, 2024

looks solvable, but maybe not as part of this PR?

I think we can get this to pass and not add too much to the other make targets by just adding the pki target as a dependency for the pr-check command? I think this could be optional as well if the ignored tests become a problem.

https://github.com/aurae-runtime/aurae/pull/518/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R100-R101

Otherwise, the make workflows that I personally use work great, and I think your changes are straight forward. Might need a rebase though as the diff doesn't seem right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants