Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable create/update the user/group running minio & add by default create_home: no #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fititnt
Copy link

@fititnt fititnt commented Jan 23, 2020

Refs #43


This pull request allow disable management from this role for the specified minio_user and minio_group (but by default keep old behavior). The variable used is minio_usergroup_manage: true (We could use other name).

This pull request also implement @SuperQ suggestion from #15 (comment). So by default if this role have to manage user, it will not try create the home directory.

About tests:

  • Tested master branch on Ubuntu 18.04 plus these changes (the lastest release had a few changes, so I also tested the master on this PR):
    • The default behavior was keep the like before (except by the create folder)
    • Did not tested full new install (but updated)
  • molecule tests to check this nea feature where not added to this initial PR.

Issues to consider when changing in production

this mote was not added to the readme, but will mention here. But this may be intuitive issue, so maybe will not work mention.

When updating the user/group from this role, consider that not only the data directories, but also a folder named .minio.sys at your root data directory may still have the older permissions values and this will make your minio instances restart too quickly.

@fititnt fititnt mentioned this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant