Fix: handle OTP28 uncompressed literals #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the try/rescue due to potential false positives on 0x78, and we need the case matching for happy path. Afaik packbeam is being unified, so this is interim quickfix. Signed-off-by: Peter M <[email protected]>
petermm
force-pushed
the
fix-uncompressed-otp28-literals
branch
from
9b16e21 to
550d22f
Compare
UncleGrumpy
reviewed
Sep 21, 2025
| try do | ||
| :zlib.uncompress(data) | ||
| rescue | ||
| _error -> data |
There was a problem hiding this comment.
Rather than try ... rescue you can match wnen <<0:32, data::binary>> sooner (before line 19 above) and only pass the data to :zlib.uncompress/1 if it later matches <<_header::binary-size(4), data::binary>>.
bettio
requested changes
Sep 23, 2025
| try do | ||
| :zlib.uncompress(data) | ||
| rescue | ||
| _error -> data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the try/rescue due to potential false positives on 0x78, and we need the case matching for happy path.
Afaik packbeam is being unified, so this is interim quickfix.
Tested main, with hello world (otp27 and otp28) - more issues with OTP28 may exist.
Fixes #57