[finishes #187942837] fixing bug in cart controller and chat model #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanIrad
requested review from
niyontwali,
Anguandia,
hozayves,
Mag-codes,
amin-leon,
patrickhag and
P-Rwirangira
JeanIrad
force-pushed
the
187942837-bg-delete-cart-item
branch
from
739b01e to
353b674
Compare
niyontwali
approved these changes
Jul 12, 2024
modified: package.json modified: src/chatSetup.ts modified: src/controllers/cartController.ts modified: src/controllers/userController.ts new file: src/database/migrations/20240712054049-remove-socketId-from-chats.js modified: src/database/models/chat.ts modified: src/routes/cartRoute.ts
JeanIrad
force-pushed
the
187942837-bg-delete-cart-item
branch
from
353b674 to
dda2889
Compare
hozayves
approved these changes
Jul 12, 2024
patrickhag
approved these changes
Jul 12, 2024
Mag-codes
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
fixing the bug in cart controller
Changes Made
I have created a delete cart item route, altered chat table removing socketId as it was not serving anything in the app, renamed the
messagetodatain the profile update responseTesting Instructions
Provide instructions on how to test the changes
Related Issues
Reference any related issues or pull requests
Checklist
Please review the following checklist and make sure all tasks are complete before submitting: