Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[finishes #187354260] Created feature that will allow sellers to upda… #64

Merged
merged 1 commit into from
May 17, 2024
Merged

[finishes #187354260] Created feature that will allow sellers to upda… #64

merged 1 commit into from
May 17, 2024

Conversation

patrickhag
Copy link
Collaborator

187354260

Purpose

  • The purpose of this PR is to enable the authenticated and authorized seller to update his/her product.

Changes Made

  • Created an endpoint for this particular use and implemented function to handle this update functionality

Testing Instructions

  • None

Related Issues

  • None

Checklist

Please review the following checklist and make sure all tasks are complete before submitting:

  • Code follows the project's coding standards
  • Changes are covered by tests
  • Documentation is updated (if applicable)
  • All tests pass

@patrickhag patrickhag added the WIP label May 13, 2024
@patrickhag patrickhag force-pushed the 187354260-update-product branch from 9e55a77 to 3c69a17 Compare May 15, 2024 21:27
amin-leon
amin-leon reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@amin-leon amin-leon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR have conflicts. try to fix it before we do the review

@patrickhag
[finishes #187354260] Created feature that will allow sellers to upda…
dc7bc15 
…te their products in stock

	modified:   src/controllers/productsController.ts
	modified:   src/helpers/claudinary.ts
	new file:   src/helpers/destroyImage.ts
	new file:   src/helpers/extractImageId.ts
	new file:   src/middlewares/handleFileUploads.ts
	modified:   src/routes/productRoutes.ts
@patrickhag patrickhag force-pushed the 187354260-update-product branch from 3c69a17 to dc7bc15 Compare May 16, 2024 15:01
@P-Rwirangira P-Rwirangira removed the WIP label May 17, 2024
P-Rwirangira
P-Rwirangira reviewed May 17, 2024
View reviewed changes
Copy link
Collaborator

@P-Rwirangira P-Rwirangira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you rebase

@niyontwali niyontwali merged commit becf88b into develop May 17, 2024
7 checks passed
P-Rwirangira pushed a commit that referenced this pull request May 20, 2024
@niyontwali @P-Rwirangira
Merge pull request #64 from atlp-rwanda/187354260-update-product
8ba5563 
[finishes #187354260] Created feature that will allow sellers to upda…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-Rwirangira P-Rwirangira P-Rwirangira approved these changes

@amin-leon amin-leon amin-leon approved these changes

@hozayves hozayves hozayves approved these changes

@niyontwali niyontwali niyontwali approved these changes

@gracemugwanezak gracemugwanezak Awaiting requested review from gracemugwanezak

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrickhag @niyontwali @hozayves @amin-leon @P-Rwirangira