Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[finishes #187354249] reset password via email #56

Merged
merged 1 commit into from
May 11, 2024

Conversation

princenzmw
Copy link
Contributor

@princenzmw princenzmw commented May 8, 2024

Purpose

Allow user to reset password via email

Changes Made

created functions in the auth controller for "forgot password" and "reset password" with their corresponding routes and documentation.

Testing Instructions

test the changes by using the endpoints '/forgot-password' and '/reset-password' in Postman

Related Issues

No related issue.

Checklist

Please review the following checklist and make sure all tasks are complete before submitting:

  • Code follows the project's coding standards
  • Changes are covered by tests
  • Documentation is updated (if applicable)
  • All tests pass

@princenzmw princenzmw added the WIP label May 8, 2024
@princenzmw princenzmw force-pushed the #187354249-ft-reset-password-via-email branch 5 times, most recently from 0c29013 to dff5883 Compare May 8, 2024 19:07
@princenzmw princenzmw added ready and removed WIP labels May 8, 2024
Copy link
Contributor

@JeanIrad JeanIrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have an excellent, concise and clear codes, only one suggested thing to take a look at, and i think you are not the one who created that verifyToken function, but you can change it to an async function.....

src/controllers/authController.ts Outdated Show resolved Hide resolved
@princenzmw
Copy link
Contributor Author

you have an excellent, concise and clear codes, only one suggested thing to take a look at, and i think you are not the one who created that verifyToken function, but you can change it to an async function.....

Thanks bro. not too much!

Copy link
Collaborator

@amin-leon amin-leon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validate this newPassword from body

src/controllers/authController.ts Show resolved Hide resolved
@princenzmw princenzmw force-pushed the #187354249-ft-reset-password-via-email branch from dff5883 to 04c3dc5 Compare May 11, 2024 17:01
@princenzmw princenzmw requested a review from amin-leon May 11, 2024 17:11
Copy link
Collaborator

@niyontwali niyontwali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please work on the feedback provide

src/controllers/authController.ts Outdated Show resolved Hide resolved
@princenzmw princenzmw force-pushed the #187354249-ft-reset-password-via-email branch from 04c3dc5 to 0f7d4a6 Compare May 11, 2024 19:36
@niyontwali niyontwali self-requested a review May 11, 2024 19:38
@princenzmw princenzmw force-pushed the #187354249-ft-reset-password-via-email branch from 0f7d4a6 to cd08408 Compare May 11, 2024 19:43
@niyontwali niyontwali merged commit 2117cb4 into develop May 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants