-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating notifications #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Favor-star
force-pushed
the
187354274-fit-notifications
branch
from
May 7, 2024 23:09
73795b8
to
bc8de9f
Compare
Favor-star
requested review from
niyontwali,
JeanIrad,
amin-leon,
patrickhag and
P-Rwirangira
May 7, 2024 23:12
hozayves
approved these changes
May 9, 2024
Favor-star
force-pushed
the
187354274-fit-notifications
branch
from
May 9, 2024 09:24
bc8de9f
to
8a7df7b
Compare
JeanIrad
reviewed
May 10, 2024
patrickhag
reviewed
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your PR looks cool and ready but consider changing this ASAP, it might take you 3 minutes.
Favor-star
force-pushed
the
187354274-fit-notifications
branch
from
May 10, 2024 15:53
8a7df7b
to
c945082
Compare
amin-leon
approved these changes
May 10, 2024
Favor-star
force-pushed
the
187354274-fit-notifications
branch
from
May 10, 2024 16:06
c945082
to
46e57ca
Compare
hozayves
approved these changes
May 10, 2024
P-Rwirangira
approved these changes
May 10, 2024
Favor-star
force-pushed
the
187354274-fit-notifications
branch
from
May 10, 2024 16:56
46e57ca
to
cfa5afb
Compare
niyontwali
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this pull request is to create the notifications related to the product creations, product update and their deletions as well.
Changes Made
Initially, they were a creation of the following fiiles:
These files were also changed, as they were some contents that had to be added. However, nothing deleted compared to what was initially there.
we are planning to include hooks in the product controllers; so that when the
Testing Instructions
No tests made yet!
Related Issues
Products is not yet merged, so I was unable to use it into my branch!
Checklist
Please review the following checklist and make sure all tasks are complete before submitting: