Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating notifications #55

Merged
merged 1 commit into from
May 10, 2024
Merged

Creating notifications #55

merged 1 commit into from
May 10, 2024

Conversation

Favor-star
Copy link
Collaborator

@Favor-star Favor-star commented May 7, 2024

Purpose

The purpose of this pull request is to create the notifications related to the product creations, product update and their deletions as well.

Changes Made

Initially, they were a creation of the following fiiles:

src/database/migrations/******-create-notification.js
src/databse/models/notification.ts
src/controllers/notificationControllers.ts
src/controllers/notificationRoutes.ts

These files were also changed, as they were some contents that had to be added. However, nothing deleted compared to what was initially there.

src/helpers/send-email.ts
src/controllers/productControllers.ts

we are planning to include hooks in the product controllers; so that when the

Testing Instructions

No tests made yet!

Related Issues

Products is not yet merged, so I was unable to use it into my branch!

Checklist

Please review the following checklist and make sure all tasks are complete before submitting:

  • Code follows the project's coding standards
  • Changes are covered by tests
  • Documentation is updated (if applicable)
  • All tests pass

@Favor-star Favor-star added the WIP label May 7, 2024
@Favor-star Favor-star requested a review from hozayves May 7, 2024 07:45
@Favor-star Favor-star force-pushed the 187354274-fit-notifications branch from 73795b8 to bc8de9f Compare May 7, 2024 23:09
@Favor-star Favor-star added ready and removed ready labels May 7, 2024
@Favor-star Favor-star force-pushed the 187354274-fit-notifications branch from bc8de9f to 8a7df7b Compare May 9, 2024 09:24
@Favor-star Favor-star added ready and removed WIP labels May 9, 2024
Copy link
Collaborator

@patrickhag patrickhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your PR looks cool and ready but consider changing this ASAP, it might take you 3 minutes.

src/controllers/notificationsController.ts Outdated Show resolved Hide resolved
src/controllers/notificationsController.ts Outdated Show resolved Hide resolved
@Favor-star Favor-star force-pushed the 187354274-fit-notifications branch from 8a7df7b to c945082 Compare May 10, 2024 15:53
@Favor-star Favor-star requested review from patrickhag and JeanIrad May 10, 2024 15:54
@niyontwali niyontwali requested a review from hozayves May 10, 2024 15:58
@Favor-star Favor-star force-pushed the 187354274-fit-notifications branch from c945082 to 46e57ca Compare May 10, 2024 16:06
@Favor-star Favor-star force-pushed the 187354274-fit-notifications branch from 46e57ca to cfa5afb Compare May 10, 2024 16:56
src/controllers/notificationsController.ts Outdated Show resolved Hide resolved
@niyontwali niyontwali merged commit 92a721f into develop May 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants