Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft-2FA two factor authentication for seller #52

Merged
merged 1 commit into from
May 7, 2024

Conversation

hozayves
Copy link
Collaborator

@hozayves hozayves commented May 2, 2024

Purpose

The goal of implementing two-factor authentication (2FA) for sellers is to enhance the security measures within the system.

Changes Made

  • Modified the authentication controller and user controller.
  • Created a new migration file for OTP (one-time password) functionality.
  • Added a new column named "enableOTP" in the user table.
  • Updated user and authentication routes.
  • Made necessary adjustments in the Swagger documentation.
  • Create a new endpoint to enable user two factor authentication

Testing Instructions

To ensure proper functionality, follow these steps:

  1. Run the migration script using npm run migration.
  2. Create a seller user.
  3. Enable 2FA for the user.
  4. Log in as a seller.
  5. Receive the OTP via email and token in postman.
  6. Paste token where it's necessary in params based on a swagger docs and OTP as body req
  7. Hint Send button

Related Issues

  • None

Checklist

Please review the following checklist and make sure all tasks are complete before submitting:

  • Code follows the project's coding standards
  • Changes are covered by tests
  • Documentation is updated (if applicable)
  • All tests pass

@hozayves hozayves added the bug Something isn't working label May 2, 2024
@hozayves hozayves force-pushed the 187354250-two-factor-authentication-for-seller branch 8 times, most recently from f5634a9 to f05309f Compare May 4, 2024 17:27
@hozayves hozayves force-pushed the 187354250-two-factor-authentication-for-seller branch from f05309f to a515a03 Compare May 6, 2024 13:42
@hozayves hozayves added ready and removed bug Something isn't working labels May 6, 2024
Copy link
Collaborator

@P-Rwirangira P-Rwirangira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ! , two factor authentication is working fine .

@niyontwali niyontwali merged commit 6ea4466 into develop May 7, 2024
7 checks passed
P-Rwirangira pushed a commit that referenced this pull request May 7, 2024
…cation-for-seller

ft-2FA two factor authentication for seller
patrickhag pushed a commit that referenced this pull request May 7, 2024
…cation-for-seller

ft-2FA two factor authentication for seller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants