[finishes #187354254] permissions and role implementation #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanIrad
requested review from
niyontwali,
Anguandia,
hozayves,
Mag-codes,
patrickhag,
Favor-star and
P-Rwirangira
Favor-star
reviewed
May 1, 2024
JeanIrad
force-pushed
the
187354254-ft-assigning-permission-role
branch
from
1d9e6bd to
fa1ee4c
Compare
which model? |
JeanIrad
force-pushed
the
187354254-ft-assigning-permission-role
branch
5 times, most recently
from
e0564f4 to
ca8aaf5
Compare
JeanIrad
force-pushed
the
187354254-ft-assigning-permission-role
branch
4 times, most recently
from
57ef4c5 to
94d7b92
Compare
amin-leon
approved these changes
May 13, 2024
JeanIrad
force-pushed
the
187354254-ft-assigning-permission-role
branch
from
94d7b92 to
0ad5698
Compare
P-Rwirangira
approved these changes
May 13, 2024
P-Rwirangira
approved these changes
May 13, 2024
JeanIrad
force-pushed
the
187354254-ft-assigning-permission-role
branch
3 times, most recently
from
046a67f to
2a662a0
Compare
inishes role and permission assigning functionality modified: package.json new file: src/controllers/permissionController.ts modified: src/controllers/roleControllers.ts new file: src/database/migrations/20240401004514-create-permissions-table.js modified: src/database/migrations/20240413203456-create-role.js renamed: src/database/migrations/20240425195548-create-user.js -> src/database/migrations/20240435195548-create-user.js new file: src/database/migrations/20240505075748-role_permissions.js new file: src/database/models/permission.ts modified: src/database/models/role.ts new file: src/database/models/rolePermissions.ts modified: src/database/models/user.ts modified: src/database/seeders/20240427082911-create-default-role.js new file: src/database/seeders/20240501105101-permissions.js new file: src/database/seeders/20240502080814-create-default-users.js new file: src/database/seeders/20240502093711-role_permissions.js new file: src/docs/permissions.yaml modified: src/middlewares/authMiddlewares.ts modified: src/routes/index.ts new file: src/routes/permissionRoute.ts modified: src/routes/roleRoute.ts new file: src/test/permissionController.test.ts Changes to be committed: new file: src/controllers/permissionController.ts modified: src/controllers/roleControllers.ts modified: src/controllers/userController.ts new file: src/controllers/vendorRequestController.ts modified: src/database/migrations/20240413203456-create-role.js modified: src/database/migrations/20240425195548-create-user.js new file: src/database/migrations/20240501104514-create-permissions-table.js new file: src/database/migrations/20240505075748-role_permissions.js new file: src/database/migrations/20240506142003-create_vendor_request_table.js modified: src/database/models/index.ts new file: src/database/models/order.ts new file: src/database/models/orderItem.ts new file: src/database/models/vendorRequest.ts modified: src/database/seeders/20240427082911-create-default-rol e.js deleted: src/database/seeders/20240429200629-add-seller-role.js new file: src/database/seeders/20240501105101-permissions.js modified: src/database/seeders/20240501163745-User.js new file: src/docs/permissions.yaml new file: src/docs/vendor.yaml modified: src/middlewares/authMiddlewares.ts modified: src/routes/index.ts new file: src/routes/permissionRoute.ts modified: src/routes/roleRoute.ts new file: src/routes/vendorRequestRoute.ts modified: src/server.ts
JeanIrad
force-pushed
the
187354254-ft-assigning-permission-role
branch
from
2a662a0 to
ee17991
Compare
niyontwali
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
implementing the functionalities where the Admin should be able to assign various users to various roles,
and each role should have permissions dedicated to it.
Changes Made
created a permission table and other permission controllers
Testing Instructions
by providing the right parameters as described in the readme file, one can have a sound test this PR
Related Issues
Not yet
Checklist
Please review the following checklist and make sure all tasks are complete before submitting: