Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: search implementation #149 #150

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

911samuel
Copy link
Contributor

What does this PR do?

This PR implements a robust and efficient search functionality for the application, allowing patients to easily search for doctors, articles, and more.

Description of Task to be completed?

  • Implement search functionality to support operations such as searching by name, category, and other attributes.
  • Add filtering capabilities by category for both doctors and articles.
  • Implement sorting for search results by trend, popularity, or other relevant factors.
  • Provide autocomplete suggestions for search queries to enhance the user experience.

How should this be manually tested?

  1. Open the application and navigate to the search page.
  2. Enter a search query for doctors or articles by name or category.
  3. Verify that the search results are displayed and can be filtered by category.
  4. Check that the search results can be sorted by trend, popularity, or other factors.
  5. Start typing a search query and verify that autocomplete suggestions are displayed.
  6. Ensure that the system handles edge cases such as no results found or invalid queries appropriately.

Any background context you want to provide?

As a patient, having a robust and efficient search functionality is crucial for easily finding relevant doctors and articles. This enhancement aims to improve the user experience by providing comprehensive search operations, including filtering, sorting, and autocomplete suggestions.

Screenshots (if appropriate)

[Attach relevant screenshots if applicable]

Questions:

[Address any questions or concerns here]

@911samuel 911samuel linked an issue Jul 20, 2024 that may be closed by this pull request
4 tasks
@911samuel 911samuel self-assigned this Jul 20, 2024
@911samuel 911samuel added Feature This is a project feature Need Review labels Jul 20, 2024
@911samuel 911samuel added this to the Integrate Key App Features milestone Jul 20, 2024
@Adadie
Copy link
Collaborator

Adadie commented Jul 22, 2024

Hey @911samuel where can I find the sorting and search by category? Only seeing search by name only!

@911samuel 911samuel force-pushed the ft-search-implementation-#149 branch 2 times, most recently from 7bedc91 to 926e9fa Compare July 22, 2024 10:08
Copy link
Contributor

@Emmyfrank Emmyfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work on comments Adadie gave you and follow feature Feature naming convention ;
check your peers naming convention on the screen bellow.
use Featue instead of using Ft

Screenshot 2024-07-22 at 12 43 25

@911samuel 911samuel changed the title Ft search implementation #149 Feature: search implementation #149 Jul 22, 2024
@911samuel 911samuel force-pushed the ft-search-implementation-#149 branch from 2e2324b to eaa2e2d Compare July 22, 2024 12:50
@911samuel
Copy link
Contributor Author

Work on comments Adadie gave you and follow feature Feature naming convention ; check your peers naming convention on the screen bellow. use Featue instead of using Ft

Screenshot 2024-07-22 at 12 43 25

Thank you! to highlight that, i corrected it

- Implement search by name, category, and other attributes
- Add filtering capabilities by category for both doctors
- Handle edge cases such as no results found and invalid queries
- Integrate logging and monitoring for search operations
- Ensure appropriate error handling and validation
@911samuel 911samuel force-pushed the ft-search-implementation-#149 branch from 9c21e87 to a9cf03f Compare July 22, 2024 13:21
@Emmyfrank
Copy link
Contributor

Work on comments Adadie gave you and follow feature Feature naming convention ; check your peers naming convention on the screen bellow. use Featue instead of using Ft
Screenshot 2024-07-22 at 12 43 25

Thank you! to highlight that, i corrected it

Now everything is cool , i managed to search a doctor by name and feature you followed feature naming convention

Copy link
Contributor

@Emmyfrank Emmyfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on comments i gave you

@911samuel 911samuel added need aprove Improvements or additions to documentation and removed Need Review labels Jul 22, 2024
@Adadie Adadie merged commit d6792b7 into dev Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This is a project feature need aprove Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Search Implementation
5 participants