Chore: Ejecting from expo managed #134

chrysloi · 2024-07-05T10:01:43Z

Chore: Ejecting from expo managed

Description

This is to eject from expo managed to enable us to run the app with the webrtc feature.

Steps to test

Android

Check if you have JDK correctly installed from terminal by running:

java --version

If it returns like below or related you can go to next step.
Otherwise find ways to configure JDK on the current os you're using.

⚠️ NB: it may vary according to OS or JDK versions

openjdk version "17.0.10" 2024-01-16 LTS
OpenJDK Runtime Environment Zulu17.48+15-CA (build 17.0.10+7-LTS)
OpenJDK 64-Bit Server VM Zulu17.48+15-CA (build 17.0.10+7-LTS, mixed mode, sharing)

Clone this repo and checkout to ch-ejecting-expo-managed

git clone [email protected]:atlp-rwanda/commanders-rn-medica.git
cd commanders-rn-medica
git checkout ch-ejecting-expo-managed
npm install

Now run the app

npm run android

IOS

Clone this repo and checkout to ch-ejecting-expo-managed

git clone [email protected]:atlp-rwanda/commanders-rn-medica.git
cd commanders-rn-medica
git checkout ch-ejecting-expo-managed
npm install

install pods

cd ./ios
pod install
cd ../

Now run the app

npm run ios

⚠️ NB:

If you're running ios and you have xcode less than 13.x.x it'll not work
if you miss a step the next might not work

Latiah · 2024-07-05T16:05:23Z

hey @chrysloi I faced this while running your pr

chrysloi · 2024-07-05T16:20:29Z

hey @chrysloi I faced this while running your pr

this seems to be compatibility issues with you JDK version please share what you get when you run java --version

also share the output you get after running npx react-native doctor

Latiah · 2024-07-05T16:54:19Z

chrysloi · 2024-07-05T18:47:04Z

@Latiah you'll need to install JDK 17 that's the suggested one as in the last versions of JDK are not supported with some of the packages. Make sure you did set the ANDROID_HOME correctly as the react-native doctor isn't finding it!

kibongos40

I'm getting this warning.

More error details at the end down

If I dismiss it, the app runs well no problem

If you want to change the appearance of status bar, you have to change UIViewControllerBasedStatusBarAppearance key in the Info.plist to YES

+[RNSScreenWindowTraits assertViewControllerBasedStatusBarAppearenceSet]
RNSScreenWindowTraits.mm:18
-[RNSScreenView setStatusBarStyle:]
__49-[RCTComponentData createPropBlock:isShadowView:]_block_invoke_10
__49-[RCTComponentData createPropBlock:isShadowView:]_block_invoke_2.110
__49-[RCTComponentData propBlockForKey:isShadowView:]_block_invoke_2
RCTPerformBlockWithLogFunction
RCTPerformBlockWithLogPrefix
__49-[RCTComponentData propBlockForKey:isShadowView:]_block_invoke
__50-[RCTComponentData setProps:forView:isShadowView:]_block_invoke
NSDICTIONARY_IS_CALLING_OUT_TO_A_BLOCK
-[__NSDictionaryM enumerateKeysAndObjectsWithOptions:usingBlock:]
-[RCTComponentData setProps:forView:isShadowView:]
-[RCTComponentData setProps:forView:]
__50-[RCTUIManager createView:viewName:rootTag:props:]_block_invoke.415
__44-[RCTUIManager flushUIBlocksWithCompletion:]_block_invoke
__44-[RCTUIManager flushUIBlocksWithCompletion:]_block_invoke.484
__RCTExecuteOnMainQueue_block_invoke
_dispatch_call_block_and_release
_dispatch_client_callout
_dispatch_main_queue_drain
_dispatch_main_queue_callback_4CF
CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE
__CFRunLoopRun
CFRunLoopRunSpecific
GSEventRunModal
-[UIApplication _run]
UIApplicationMain
main
start_sim
0x0

Latiah · 2024-07-08T21:06:28Z

@Latiah you'll need to install JDK 17 that's the suggested one as in the last versions of JDK are not supported with some of the packages. Make sure you did set the ANDROID_HOME correctly as the react-native doctor isn't finding it!

Thanks .After setting up everything correctly I was able to run the app everything is fine I encountered 0 errors

chrysloi · 2024-07-09T07:36:39Z

I'm getting this warning.

More error details at the end down

If I dismiss it, the app runs well no problem

If you want to change the appearance of status bar, you have to change UIViewControllerBasedStatusBarAppearance key in the Info.plist to YES

+[RNSScreenWindowTraits assertViewControllerBasedStatusBarAppearenceSet] RNSScreenWindowTraits.mm:18 -[RNSScreenView setStatusBarStyle:] __49-[RCTComponentData createPropBlock:isShadowView:]_block_invoke_10 __49-[RCTComponentData createPropBlock:isShadowView:]_block_invoke_2.110 __49-[RCTComponentData propBlockForKey:isShadowView:]_block_invoke_2 RCTPerformBlockWithLogFunction RCTPerformBlockWithLogPrefix __49-[RCTComponentData propBlockForKey:isShadowView:]_block_invoke __50-[RCTComponentData setProps:forView:isShadowView:]_block_invoke NSDICTIONARY_IS_CALLING_OUT_TO_A_BLOCK -[__NSDictionaryM enumerateKeysAndObjectsWithOptions:usingBlock:] -[RCTComponentData setProps:forView:isShadowView:] -[RCTComponentData setProps:forView:] __50-[RCTUIManager createView:viewName:rootTag:props:]_block_invoke.415 __44-[RCTUIManager flushUIBlocksWithCompletion:]_block_invoke __44-[RCTUIManager flushUIBlocksWithCompletion:]_block_invoke.484 __RCTExecuteOnMainQueue_block_invoke _dispatch_call_block_and_release _dispatch_client_callout _dispatch_main_queue_drain _dispatch_main_queue_callback_4CF CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE __CFRunLoopRun CFRunLoopRunSpecific GSEventRunModal -[UIApplication _run] UIApplicationMain main start_sim 0x0

@kibongos40 That's addressed, Please check again!

911samuel · 2024-07-10T08:25:53Z

it it failing on my device

fredshema

The app is starting correctly on android. Nice work👍🏽

Emmyfrank · 2024-07-12T13:12:32Z

The app is starting correctly on android. Nice work👍🏽

ok which is good

gitguardian · 2024-07-12T13:17:30Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

addressing requested changes

911samuel

Great work! issue was on my android studion sdk now resolved

kibongos40

Now it works

mukunzidd

LGTM

chrysloi added Chore Define what a chore is Need Review labels Jul 5, 2024

chrysloi requested review from fredshema, kibongos40, Emmyfrank, Latiah, 911samuel, justinmihigo and twizerim July 5, 2024 10:01

chrysloi self-assigned this Jul 5, 2024

kibongos40 requested changes Jul 8, 2024

View reviewed changes

Latiah approved these changes Jul 8, 2024

View reviewed changes

chrysloi force-pushed the ch-ejecting-expo-managed branch from 3ce4512 to 710dc0b Compare July 9, 2024 07:32

chrysloi requested a review from kibongos40 July 9, 2024 07:39

chrysloi force-pushed the ch-ejecting-expo-managed branch from 710dc0b to 863cd6b Compare July 9, 2024 15:29

fredshema approved these changes Jul 12, 2024

View reviewed changes

chrysloi force-pushed the ch-ejecting-expo-managed branch from 863cd6b to 9787eb5 Compare July 12, 2024 13:13

chrysloi force-pushed the ch-ejecting-expo-managed branch 2 times, most recently from 9787eb5 to 67cdf52 Compare July 12, 2024 14:26

chore:(Ejecting from expo managed to expo bare react-native)

ee3f18a

addressing requested changes

chrysloi force-pushed the ch-ejecting-expo-managed branch from 67cdf52 to ee3f18a Compare July 12, 2024 14:28

911samuel approved these changes Jul 18, 2024

View reviewed changes

kibongos40 approved these changes Jul 18, 2024

View reviewed changes

chrysloi added need aprove Improvements or additions to documentation and removed Need Review need aprove Improvements or additions to documentation labels Jul 22, 2024

mukunzidd approved these changes Jul 22, 2024

View reviewed changes

mukunzidd merged commit 92ea656 into dev Jul 22, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore: Ejecting from expo managed #134

Chore: Ejecting from expo managed #134

chrysloi commented Jul 5, 2024 •

edited

Loading

Latiah commented Jul 5, 2024

chrysloi commented Jul 5, 2024 •

edited

Loading

Latiah commented Jul 5, 2024

chrysloi commented Jul 5, 2024 •

edited

Loading

kibongos40 left a comment

Latiah commented Jul 8, 2024

chrysloi commented Jul 9, 2024 •

edited

Loading

I'm getting this warning.

More error details at the end down

If I dismiss it, the app runs well no problem

911samuel commented Jul 10, 2024

fredshema left a comment

Emmyfrank commented Jul 12, 2024

gitguardian bot commented Jul 12, 2024 •

edited

Loading

911samuel left a comment

kibongos40 left a comment

mukunzidd left a comment

Chore: Ejecting from expo managed #134

Chore: Ejecting from expo managed #134

Conversation

chrysloi commented Jul 5, 2024 • edited Loading

Chore: Ejecting from expo managed

Description

Steps to test

Android

IOS

Latiah commented Jul 5, 2024

chrysloi commented Jul 5, 2024 • edited Loading

Latiah commented Jul 5, 2024

chrysloi commented Jul 5, 2024 • edited Loading

kibongos40 left a comment

Choose a reason for hiding this comment

I'm getting this warning.

More error details at the end down

If I dismiss it, the app runs well no problem

Latiah commented Jul 8, 2024

chrysloi commented Jul 9, 2024 • edited Loading

I'm getting this warning.

More error details at the end down

If I dismiss it, the app runs well no problem

911samuel commented Jul 10, 2024

fredshema left a comment

Choose a reason for hiding this comment

Emmyfrank commented Jul 12, 2024

gitguardian bot commented Jul 12, 2024 • edited Loading

️✅ There are no secrets present in this pull request anymore.

911samuel left a comment

Choose a reason for hiding this comment

kibongos40 left a comment

Choose a reason for hiding this comment

mukunzidd left a comment

Choose a reason for hiding this comment

chrysloi commented Jul 5, 2024 •

edited

Loading

chrysloi commented Jul 5, 2024 •

edited

Loading

chrysloi commented Jul 5, 2024 •

edited

Loading

chrysloi commented Jul 9, 2024 •

edited

Loading

gitguardian bot commented Jul 12, 2024 •

edited

Loading