-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#187854921: Add Seller and Admin Dashboard Features #46
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4b6e98c
to
a91b697
Compare
a91b697
to
17b8893
Compare
17b8893
to
0e80c01
Compare
0e80c01
to
7baef6a
Compare
7baef6a
to
a45840e
Compare
a45840e
to
0582cad
Compare
0582cad
to
2a9740f
Compare
2a9740f
to
da9a6ff
Compare
da9a6ff
to
d01666c
Compare
d01666c
to
67ef90c
Compare
67ef90c
to
ab3ddcf
Compare
ab3ddcf
to
d1e2e82
Compare
d1e2e82
to
fe10013
Compare
cfaa959
to
4e0f87a
Compare
4e0f87a
to
57d44b8
Compare
57d44b8
to
732bdec
Compare
732bdec
to
b6bcb1a
Compare
b6bcb1a
to
6a58e69
Compare
6a58e69
to
89b769e
Compare
89b769e
to
351e254
Compare
351e254
to
6aad0f9
Compare
6aad0f9
to
3775755
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve all feedback.
@@ -1,4 +1,4 @@ | |||
"use client"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This endpoint src/app/(profile)/profile-edit/...
does not not follow our naming conventions. It has to be something close to .../profile/[profileId]
.
if (response.payload && response.payload.User) { | ||
currentProfile.User = response.payload.User; | ||
console.log("currentProfile", currentProfile); | ||
console.log('currentProfile', currentProfile); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these consoles.
<li className='flex items-center text-gray-600'> | ||
<svg className='w-4 h-4 mr-2' fill='none' stroke='currentColor' viewBox='0 0 24 24' xmlns='http://www.w3.org/2000/svg'><path strokeLinecap='round' strokeLinejoin='round' strokeWidth={2} d='M8 7V3m8 4V3m-9 8h10M5 21h14a2 2 0 002-2V7a2 2 0 00-2-2H5a2 2 0 00-2 2v12a2 2 0 002 2z' /></svg> | ||
{watchedValues.birthDate || "YYYY-MM-DD"} | ||
<ul className="hidden md:block text-sm space-y-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is too long. You are probably not using reusable components. Refactor this component by dividing it into smaller components that perform specific tasks.
@@ -0,0 +1,43 @@ | |||
'use client'; | |||
import React, { useEffect, useState } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page endpoint is wrong, and I have mentioned this several times.
|
||
useEffect(() => { | ||
const categ = async () => { | ||
const responsecat: any = await request.get(`/products/${productId}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use any
src/components/2faVerification.tsx
Outdated
@@ -32,7 +31,7 @@ const OtpVerify: React.FC<OtpVerifyInterface> = ({ isOpen }) => { | |||
|
|||
useEffect(() => { | |||
if (isAuthenticated) { | |||
router.push('/seller/dashboard/products'); | |||
router.push('/dashboard/home'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/dashboard/home
endpoint does not make sense.
</div> | ||
); | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component is too long. You have to rafactor it.
3775755
to
62ebac3
Compare
62ebac3
to
32f14cd
Compare
32f14cd
to
bcbfd5d
Compare
bcbfd5d
to
d3163af
Compare
What does this PR do?
Dashboard
Description of Task to be completed?
Two different dashboards based on the type of user who are logged in and all work smoothly with functionalities.
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker/Trello stories?
https://www.pivotaltracker.com/n/projects/2698211/stories/187854921
Screenshots (if appropriate)
Questions: