Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#397 admin-update-teams #491

Merged
merged 2 commits into from
Sep 27, 2024
Merged

#397 admin-update-teams #491

merged 2 commits into from
Sep 27, 2024

Conversation

Tuyisenge2
Copy link
Contributor

@Tuyisenge2 Tuyisenge2 commented Sep 12, 2024

PR Description

this PR is impleting how admin can update the information of teams like admin will change corhort ,ttl,name of teams

How has this been tested?

step 1:clone this repository
step 2: install packages
step 3: start server by npm run dev
step4: log in with admin account and go on teams items in sidebar
step5: click on update icon in teams table

important point to consider

on editing phase and program I’ve noticed that when creating a team, we only specify the cohort, name, TTL, and start date. Other team details, like the phase and program, seem to be determined based on the cohort. Specifically, a team’s phase is the same as its cohort’s phase.
So, considering that phase and program depend on the cohort, I suggest that instead of allowing the admin to update the phase and program directly, they should only update the cohort. The phase and program would automatically adjust based on the new cohort.
so here what we are changing is cohort and team get new program and phase from cohort

Number of Commits

single comits

Screenshots (If appropriate)

before this PR
image
after this PR
image

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 5:20pm

Copy link
Contributor

@JacquelineTuyisenge JacquelineTuyisenge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write the PR description well
ex:
remove these:
Please include a brief description of the pull request you want to raise

@Tuyisenge2 Tuyisenge2 removed the enhancement New feature or request label Sep 16, 2024
@JacquelineTuyisenge JacquelineTuyisenge added work on feedback work on feedback and removed Need Reviews labels Sep 17, 2024
@JacquelineTuyisenge JacquelineTuyisenge removed the work on feedback work on feedback label Sep 18, 2024
@Tuyisenge2 Tuyisenge2 added the enhancement New feature or request label Sep 19, 2024
@Salim-54 Salim-54 merged commit 1393242 into develop Sep 27, 2024
6 checks passed
@ceelogre ceelogre deleted the fix-admin-can-update-teams branch September 30, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Nova Team Nova Ready For Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement on Teams Page
6 participants