-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#397 admin-update-teams #491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tuyisenge2
requested review from
ceelogre,
shema-surge,
ncutixavier,
Salim-54,
Bananayosostene,
JacquelineTuyisenge,
Dawaic6,
RWEMAREMY,
janet-barbie,
shebz2023 and
musabehonore
September 12, 2024 21:55
janet-barbie
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write the PR description well
ex:
remove these:
Please include a brief description of the pull request you want to raise
JacquelineTuyisenge
approved these changes
Sep 15, 2024
shebz2023
approved these changes
Sep 16, 2024
musabehonore
approved these changes
Sep 16, 2024
JacquelineTuyisenge
added
work on feedback
work on feedback
and removed
Need Reviews
labels
Sep 17, 2024
JacquelineTuyisenge
approved these changes
Sep 20, 2024
musabehonore
approved these changes
Sep 21, 2024
janet-barbie
force-pushed
the
fix-admin-can-update-teams
branch
from
September 26, 2024 09:43
8ca42bc
to
3634c4d
Compare
janet-barbie
force-pushed
the
fix-admin-can-update-teams
branch
from
September 26, 2024 11:36
3634c4d
to
9573452
Compare
Tuyisenge2
force-pushed
the
fix-admin-can-update-teams
branch
from
September 26, 2024 14:08
9573452
to
8053291
Compare
Tuyisenge2
force-pushed
the
fix-admin-can-update-teams
branch
from
September 26, 2024 17:19
8053291
to
2ee5ca1
Compare
JacquelineTuyisenge
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
this PR is impleting how admin can update the information of teams like admin will change corhort ,ttl,name of teams
How has this been tested?
step 1:clone this repository
step 2: install packages
step 3: start server by npm run dev
step4: log in with admin account and go on teams items in sidebar
step5: click on update icon in teams table
important point to consider
on editing phase and program I’ve noticed that when creating a team, we only specify the cohort, name, TTL, and start date. Other team details, like the phase and program, seem to be determined based on the cohort. Specifically, a team’s phase is the same as its cohort’s phase.
So, considering that phase and program depend on the cohort, I suggest that instead of allowing the admin to update the phase and program directly, they should only update the cohort. The phase and program would automatically adjust based on the new cohort.
so here what we are changing is cohort and team get new program and phase from cohort
Number of Commits
single comits
Screenshots (If appropriate)
before this PR
after this PR
Please check this Checklist before you submit your PR: