-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fetch trainees on attendance #313
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NdatimanaSamuel
requested review from
rukundo-kevin,
KAYITARES,
Muhet,
madebypatrick,
Gentille-dev and
NTElissa
October 12, 2023 11:41
NdatimanaSamuel
force-pushed
the
fix-fetchTraineesAttendance
branch
from
October 12, 2023 11:46
2a97e41
to
864952f
Compare
NdatimanaSamuel
force-pushed
the
fix-fetchTraineesAttendance
branch
from
October 12, 2023 12:21
864952f
to
9d71d2c
Compare
NdatimanaSamuel
force-pushed
the
fix-fetchTraineesAttendance
branch
from
October 12, 2023 12:30
9d71d2c
to
b9fa143
Compare
NdatimanaSamuel
force-pushed
the
fix-fetchTraineesAttendance
branch
from
October 12, 2023 13:03
b9fa143
to
7431024
Compare
NdatimanaSamuel
force-pushed
the
fix-fetchTraineesAttendance
branch
from
October 12, 2023 13:10
7431024
to
7155681
Compare
NdatimanaSamuel
force-pushed
the
fix-fetchTraineesAttendance
branch
from
October 12, 2023 14:07
7155681
to
c583f2f
Compare
Virgile1k
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked and approved
Charlesntwari
approved these changes
Oct 12, 2023
mken1205
approved these changes
Oct 12, 2023
madebypatrick
approved these changes
Oct 12, 2023
NdatimanaSamuel
force-pushed
the
fix-fetchTraineesAttendance
branch
from
October 13, 2023 07:57
c583f2f
to
7978fa7
Compare
NdatimanaSamuel
force-pushed
the
fix-fetchTraineesAttendance
branch
from
October 13, 2023 08:06
7978fa7
to
9d8122d
Compare
ceelogre
requested changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentille-dev
approved these changes
Oct 20, 2023
- use enum instead of literal string
NdatimanaSamuel
force-pushed
the
fix-fetchTraineesAttendance
branch
from
October 20, 2023 14:56
9d8122d
to
119b61f
Compare
Gentille-dev
approved these changes
Oct 23, 2023
NdatimanaSamuel
force-pushed
the
fix-fetchTraineesAttendance
branch
from
October 27, 2023 09:00
bd089fc
to
a21d27e
Compare
Re-implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
this PR ,fix fetching of trainees on attendance list where if trainees is added by admin can be displayed even on coordinator attendance
List all the tasks and sub-tasks that were assigned to you or that you assigned yourself. Make sure you check every completed task.
How has this been tested?
-pull this PR
-run both server and frontend
-login as coordinator or admin and add trainees will be appeared on dashboard of coordinator on attendance
Number of Commits
1
Screenshots (If appropriate)
Please check this Checklist before you submit your PR: