Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetch trainees on attendance #313

Closed
wants to merge 2 commits into from

Conversation

NdatimanaSamuel
Copy link
Contributor

@NdatimanaSamuel NdatimanaSamuel commented Oct 4, 2023

PR Description

this PR ,fix fetching of trainees on attendance list where if trainees is added by admin can be displayed even on coordinator attendance

List all the tasks and sub-tasks that were assigned to you or that you assigned yourself. Make sure you check every completed task.

How has this been tested?

-pull this PR
-run both server and frontend
-login as coordinator or admin and add trainees will be appeared on dashboard of coordinator on attendance

Number of Commits

1

Screenshots (If appropriate)

showtrainees

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 9:01am

Copy link

@Virgile1k Virgile1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and approved

Copy link
Contributor

@ceelogre ceelogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to rate attendance, it says week does not exist. Also remove log messages in the console.
image

- use enum instead of literal string
@ceelogre
Copy link
Contributor

Re-implemented.

@ceelogre ceelogre closed this Sep 26, 2024
@ceelogre ceelogre deleted the fix-fetchTraineesAttendance branch September 30, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants