Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# 409: Sending an email corresponding to the action done when a trainee is added to a cohort #415

Closed
wants to merge 1 commit into from

Conversation

GSinseswa721
Copy link
Contributor

@GSinseswa721 GSinseswa721 commented Nov 6, 2024

PR Description

This pull request improves the email notification sent when a trainee is added to a cohort. The updated message now clearly informs the trainee that they have been added to both a specific cohort and team within the organization.

Description of tasks that were expected to be completed

  • Updated email template to specify that the trainee is added to a specific cohort and team.
  • Modified message content to include detailed information about both the cohort and team names.
  • Ensured the email contains a link for the trainee to log in and access relevant resources.

Functionality

When a trainee is added to a cohort, an email is triggered to notify them. This email now provides clear details about their assigned cohort and team within the organization

How has this been tested?

https://devpulse-backend-pr-415.onrender.com/

  • Manually tested by adding a trainee to a cohort and verifying that the email displays both the cohort and team information accurately.
  • Confirmed that the email content reflects the correct cohort and team names.
  • Checked that the login link redirects the user to the correct page.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@d68b43b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/cohort.resolvers.ts 0.00% 4 Missing ⚠️
src/resolvers/eventResolver.ts 0.00% 2 Missing ⚠️
src/resolvers/ratingsResolvers.ts 0.00% 2 Missing ⚠️
src/helpers/organization.helper.ts 0.00% 1 Missing ⚠️
src/helpers/sendEventEmails.ts 0.00% 1 Missing ⚠️
src/resolvers/coordinatorResolvers.ts 66.66% 1 Missing ⚠️
src/resolvers/resolver.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #415   +/-   ##
==========================================
  Coverage           ?   16.57%           
==========================================
  Files              ?       89           
  Lines              ?     3559           
  Branches           ?     1019           
==========================================
  Hits               ?      590           
  Misses             ?     2960           
  Partials           ?        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GSinseswa721 GSinseswa721 added the Needs Reviews A pull request need reviews to be merged label Nov 13, 2024
@niyobertin niyobertin added the fighters Team label Nov 14, 2024
@ceelogre ceelogre temporarily deployed to fx-email-trainee - devpulse-backend PR #415 November 14, 2024 12:19 — with Render Destroyed
@GSinseswa721 GSinseswa721 changed the title Fx email trainee # 409: Fix email trainee Nov 14, 2024
@niyobertin niyobertin changed the title # 409: Fix email trainee # 409: Sending an email corresponding to the action done when a trainee is added to a cohort Nov 14, 2024
@ceelogre ceelogre temporarily deployed to fix-emai-trainne - devpulse-backend PR #424 November 14, 2024 15:55 — with Render Destroyed
* Added missing secret in env

* test: deployment

* feat: run the action on push

---------

Co-authored-by: ceelogre <[email protected]>

sort invitations in descending order

sort  invitations by ascending or descending order

sort  invitations by ascending or descending order

fix(#409):correcting email sent to a trainee

fix(#409):correcting email sent to a trainee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fighters Team Needs Reviews A pull request need reviews to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants