Fix/missing secret env #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #402 +/- ##
==========================================
Coverage ? 16.58%
==========================================
Files ? 89
Lines ? 3558
Branches ? 1019
==========================================
Hits ? 590
Misses ? 2959
Partials ? 9 ☔ View full report in Codecov by Sentry. |
MugemaneBertin2001
force-pushed
the
fix/missing-secret-env
branch
from
cd80dd8
to
be2933b
Compare
MugemaneBertin2001
requested review from
ceelogre,
niyobertin and
JacquelineTuyisenge
niyobertin
approved these changes
Oct 30, 2024
MugemaneBertin2001
force-pushed
the
fix/missing-secret-env
branch
from
be2933b
to
12d0a6e
Compare
YvetteNyibuka
approved these changes
Oct 30, 2024
ceelogre
requested changes
Oct 30, 2024
MugemaneBertin2001
force-pushed
the
fix/missing-secret-env
branch
from
12d0a6e
to
ce4c6e4
Compare
MugemaneBertin2001
force-pushed
the
fix/missing-secret-env
branch
from
ce4c6e4
to
eabb47b
Compare
MugemaneBertin2001
force-pushed
the
fix/missing-secret-env
branch
from
eabb47b
to
96a7dbb
Compare
MugemaneBertin2001
force-pushed
the
fix/missing-secret-env
branch
from
96a7dbb
to
1ea5edb
Compare
@ceelogre, please take another look and try the beta. After removing You can review it at beta.devpulse.org. Once you've reviewed and approved, I'll remove the following section before merging: pull_request:
branches:
- develop |
MugemaneBertin2001
force-pushed
the
fix/missing-secret-env
branch
from
1ea5edb
to
dc41b72
Compare
MugemaneBertin2001
force-pushed
the
fix/missing-secret-env
branch
from
dc41b72
to
ddcb876
Compare
|
Resolve the conflicts |
MugemaneBertin2001
force-pushed
the
fix/missing-secret-env
branch
from
ddcb876
to
4dc4be4
Compare
Salim-54
approved these changes
Nov 1, 2024
ceelogre
temporarily deployed
to
fix/missing-secret-env - devpulse-backend PR #402
Render
Destroyed
ceelogre
approved these changes
Nov 11, 2024
elijahladdie
pushed a commit
that referenced
this pull request
Nov 11, 2024
* Added missing secret in env * test: deployment * feat: run the action on push --------- Co-authored-by: ceelogre <[email protected]>
elijahladdie
pushed a commit
that referenced
this pull request
Nov 12, 2024
* Added missing secret in env * test: deployment * feat: run the action on push --------- Co-authored-by: ceelogre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This fix adds missing SECRET variable in env during building docker image.