Fix trainee dashboard #381
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanu-cast
requested review from
rwemakevin,
aimedivin,
elijahladdie,
Calebgisa72,
Salim-54 and
ceelogre
kanu-cast
force-pushed
the
fix-trainee-dashboard
branch
from
07c8341
to
22ff34b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #381 +/- ##
==========================================
Coverage ? 16.57%
==========================================
Files ? 89
Lines ? 3560
Branches ? 1008
==========================================
Hits ? 590
Misses ? 2961
Partials ? 9 ☔ View full report in Codecov by Sentry. |
kanu-cast
force-pushed
the
fix-trainee-dashboard
branch
from
22ff34b
to
45c4fe3
Compare
ceelogre
temporarily deployed
to
fix-trainee-dashboard - devpulse-backend PR #381
Render
Destroyed
kanu-cast
force-pushed
the
fix-trainee-dashboard
branch
from
45c4fe3
to
0f45417
Compare
elijahladdie
approved these changes
Nov 1, 2024
ceelogre
requested changes
Nov 2, 2024
src/schema/index.ts
Outdated
Comment on lines
658
to
676
| type traineeAttendanceWeek { | ||
| week: Int! | ||
| weekAverage: String! | ||
| daysStatus: AttendanceDates! | ||
| } | ||
|
|
||
| type traineeAttendancePhase { | ||
| phase: Phase! | ||
| phaseAverage: String! | ||
| weeks: [traineeAttendanceWeek]! | ||
| } | ||
|
|
||
| type traineeAttendance { | ||
| traineeId: String! | ||
| teamName: String! | ||
| allPhasesAverage: String! | ||
| phases: [traineeAttendancePhase]! | ||
| } |
There was a problem hiding this comment.
Is it necessary to break these into separate types?
There was a problem hiding this comment.
I think this should go to the team that has been working on attendance as i never altered any of these types and i think if i do alter or combine these types it might affect their work. Thanks
kanu-cast
force-pushed
the
fix-trainee-dashboard
branch
from
0f45417
to
4ad8271
Compare
ceelogre
temporarily deployed
to
fix-trainee-dashboard - devpulse-backend PR #381
Render
Destroyed
kanu-cast
force-pushed
the
fix-trainee-dashboard
branch
from
4ad8271
to
0c0355d
Compare
kanu-cast
force-pushed
the
fix-trainee-dashboard
branch
from
0c0355d
to
c2d136a
Compare
kanu-cast
force-pushed
the
fix-trainee-dashboard
branch
from
c2d136a
to
1eab8b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
extending rating schema to include createdAt and updatedAt attributes
Description of tasks that were expected to be completed
simply added createdAt and updatedAt on the Rating schema