Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't read undefined of organization while creating new organization #359

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

elijahladdie
Copy link
Contributor

@elijahladdie elijahladdie commented Oct 14, 2024

fix: can't read undefined of organization while creating new organization

PR Description

Please include a brief description of the pull request you want to raise.

Description of tasks that were expected to be completed

  • I added ? before organization in team resolver while getting teams

Functionality

  • navigate to create team menu. and you won't find any warning or error toast message that tasks about it.

How has this been tested?

i created new team to make sure that before I select new

PR Checklist:

  • ? is added to make sure application won't crash if the organization is not available

@elijahladdie elijahladdie changed the title fix: can't read undefinded of origanization while creating new organi… fix: can't read undefineded of organization while creating new organization Oct 14, 2024
@elijahladdie elijahladdie changed the title fix: can't read undefineded of organization while creating new organization fix: can't read undefined of organization while creating new organization Oct 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@c99966a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/team.resolvers.ts 0.00% 7 Missing ⚠️
src/context.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #359   +/-   ##
==========================================
  Coverage           ?   17.31%           
==========================================
  Files              ?       86           
  Lines              ?     3159           
  Branches           ?      913           
==========================================
  Hits               ?      547           
  Misses             ?     2602           
  Partials           ?       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -450,8 +457,10 @@ const resolvers = {

if (role !== RoleOfUser.SUPER_ADMIN) {
const org = await checkLoggedInOrganization(orgToken)

if (cohortOrg.id.toString() !== org.id.toString()) {
console.log('>>>>>>>>>>>>>')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elijahladdie remove these console.logs

@@ -46,7 +46,10 @@ export const context = async ({ req }: { req: Request }): Promise<Context> => {
if (
Copy link
Contributor

@aimedivin aimedivin Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elijahladdie , also look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants