Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#272 Admin delete user #300

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

Christian-Ishimwe
Copy link
Contributor

@Christian-Ishimwe Christian-Ishimwe commented Sep 15, 2024

PR Description

This PR Allows the admins, the super admin to delete the user.

Description of tasks to be completed

  • Admin should be able to delete the user
  • We should notify the admin when he deletes the TTL with the Team
  • We should notify the admin when he deletes the Coordinator
  • We should make the TTL and coordinators null when deleted

How should it be tested

  1. Clone this repo
  2. checkout to the branch: git checkout ft-deleteuser-272
  3. install the packages by npm install
  4. make sure the set the .env variales as described in .env.example
  5. run seed by npm run seed
  6. After, use the graphql,apollo server to sign in as the admin

PR Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • My code generates no warnings.
  • I have commented my code, particularly in hard-to-understand areas.
  • My test coverage meets the set test coverage threshold.
  • There are no vulnerabilities.
  • There are no conflicts with the base branch.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@fe7a224). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/userResolver.ts 4.34% 22 Missing ⚠️
src/resolvers/cohort.resolvers.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #300   +/-   ##
==========================================
  Coverage           ?   18.43%           
==========================================
  Files              ?       82           
  Lines              ?     2669           
  Branches           ?      756           
==========================================
  Hits               ?      492           
  Misses             ?     2175           
  Partials           ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elijahladdie elijahladdie added the Needs Reviews A pull request need reviews to be merged label Sep 16, 2024
@elijahladdie elijahladdie linked an issue Sep 16, 2024 that may be closed by this pull request
Copy link
Contributor

@aimedivin aimedivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Christian-Ishimwe , @elijahladdie
Work on requested changes on FE make sure you also updates BE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Reviews A pull request need reviews to be merged ready for review steppers Steppers Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete user
5 participants