Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#242-CRUD Operations for tickets #287

Merged
merged 1 commit into from
Sep 27, 2024
Merged

#242-CRUD Operations for tickets #287

merged 1 commit into from
Sep 27, 2024

Conversation

MugemaneBertin2001
Copy link
Contributor

@MugemaneBertin2001 MugemaneBertin2001 commented Sep 11, 2024

PR Description

This PR implements CRUD operations for ticket management. It includes the creation, retrieval, update, and deletion of tickets, as well as necessary GraphQL resolvers and mutations.

Description of tasks that were expected to be completed

  • Implemented GraphQL resolvers for CRUD operations on tickets.
  • Added createTicket, getAllTickets, updateTicket, and deleteTicket replyToTicket, closeTicket , mutations.
  • Integrated ticket creation and update functionality with push notifications.
  • Added access control checks based on user roles.
  • Updated ticket status and validation logic.
  • Ensured proper error handling and response messages.

Functionality

  • Clone the repository.
  • git checkout ft-tickets-crud-#242
  • Install dependencies with npm install.
  • Start the development server with npm run dev.
  • Test the ticket CRUD operations using GraphQL Playground or Postman.

How has this been tested?

  • Tested the creation, retrieval, updating, and deletion of tickets using GraphQL queries and mutations.
  • Verified access control and role-based restrictions.
  • Checked error handling and response messages for various scenarios.

PR Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • My code generates no warnings.
  • I have commented my code, particularly in hard-to-understand areas.
  • My test coverage meets the set test coverage threshold.
  • There are no vulnerabilities.
  • There are no conflicts with the base branch.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 3.84615% with 100 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@0b5475a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/ticket.resolver.ts 1.16% 85 Missing ⚠️
src/resolvers/coordinatorResolvers.ts 0.00% 13 Missing ⚠️
src/models/ticket.model.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #287   +/-   ##
==========================================
  Coverage           ?   18.32%           
==========================================
  Files              ?       82           
  Lines              ?     2680           
  Branches           ?      765           
==========================================
  Hits               ?      491           
  Misses             ?     2187           
  Partials           ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aimedivin aimedivin added Ready for merge The pull request has received all necessary reviews and can be merged and removed ready for review labels Sep 16, 2024
@aimedivin aimedivin self-requested a review September 17, 2024 09:54
Copy link
Contributor

@aimedivin aimedivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amiparadis250 , @MugemaneBertin2001 Pls ensure that a TTL can also perform CRUD operation on ticket .

@ceelogre ceelogre temporarily deployed to ft-tickets-crud-#242 - devpulse-backend PR #287 September 18, 2024 21:48 — with Render Destroyed
@Salim-54 Salim-54 merged commit c456188 into develop Sep 27, 2024
2 checks passed
@ceelogre ceelogre deleted the ft-tickets-crud-#242 branch October 1, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for merge The pull request has received all necessary reviews and can be merged steppers Steppers Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRUD Operations for tickets