Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#242-CRUD Operations for tickets #287

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

#242-CRUD Operations for tickets #287

wants to merge 1 commit into from
+586 −449

Conversation

MugemaneBertin2001
Copy link
Contributor

@MugemaneBertin2001 MugemaneBertin2001 commented Sep 11, 2024 •
edited
Loading

PR Description

This PR implements CRUD operations for ticket management. It includes the creation, retrieval, update, and deletion of tickets, as well as necessary GraphQL resolvers and mutations.

Description of tasks that were expected to be completed

  • Implemented GraphQL resolvers for CRUD operations on tickets.
  • Added createTicket, getAllTickets, updateTicket, and deleteTicket replyToTicket, closeTicket , mutations.
  • Integrated ticket creation and update functionality with push notifications.
  • Added access control checks based on user roles.
  • Updated ticket status and validation logic.
  • Ensured proper error handling and response messages.

Functionality

  • Clone the repository.
  • git checkout ft-tickets-crud-#242
  • Install dependencies with npm install.
  • Start the development server with npm run dev.
  • Test the ticket CRUD operations using GraphQL Playground or Postman.

How has this been tested?

  • Tested the creation, retrieval, updating, and deletion of tickets using GraphQL queries and mutations.
  • Verified access control and role-based restrictions.
  • Checked error handling and response messages for various scenarios.

PR Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • My code generates no warnings.
  • I have commented my code, particularly in hard-to-understand areas.
  • My test coverage meets the set test coverage threshold.
  • There are no vulnerabilities.
  • There are no conflicts with the base branch.

@MugemaneBertin2001 MugemaneBertin2001 added the steppers Steppers Team label Sep 11, 2024
@MugemaneBertin2001 MugemaneBertin2001 linked an issue Sep 11, 2024 that may be closed by this pull request
CRUD Operations for tickets #242
Open
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 3.84615% with 100 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@0b5475a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/ticket.resolver.ts 1.16% 85 Missing ⚠️
src/resolvers/coordinatorResolvers.ts 0.00% 13 Missing ⚠️
src/models/ticket.model.ts 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             develop     #287   +/-   ##
==========================================
  Coverage           ?   18.32%           
==========================================
  Files              ?       82           
  Lines              ?     2680           
  Branches           ?      765           
==========================================
  Hits               ?      491           
  Misses             ?     2187           
  Partials           ?        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aimedivin aimedivin added Ready for merge The pull request has received all necessary reviews and can be merged and removed ready for review labels Sep 16, 2024
@aimedivin aimedivin self-requested a review September 17, 2024 09:54
aimedivin
aimedivin requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@aimedivin aimedivin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amiparadis250 , @MugemaneBertin2001 Pls ensure that a TTL can also perform CRUD operation on ticket .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacifiquemboni pacifiquemboni pacifiquemboni approved these changes

@kanu-cast kanu-cast kanu-cast approved these changes

@elijahladdie elijahladdie elijahladdie approved these changes

@aimedivin aimedivin aimedivin approved these changes

@amiparadis250 amiparadis250 amiparadis250 approved these changes

@Calebgisa72 Calebgisa72 Calebgisa72 approved these changes

@ceelogre ceelogre Awaiting requested review from ceelogre

@ncutixavier ncutixavier Awaiting requested review from ncutixavier

@Salim-54 Salim-54 Awaiting requested review from Salim-54

Assignees

@MugemaneBertin2001 MugemaneBertin2001

@amiparadis250 amiparadis250

Labels
Ready for merge The pull request has received all necessary reviews and can be merged steppers Steppers Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRUD Operations for tickets
10 participants
@MugemaneBertin2001 @codecov-commenter @pacifiquemboni @kanu-cast @elijahladdie @aimedivin @amiparadis250 @Calebgisa72 @ceelogre @hatfelicien