Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#109 ft implementation role permission update #96

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

iChris-tian
Copy link
Contributor

@iChris-tian iChris-tian commented Sep 18, 2024

Description

This PR changes the mutation settings that changed the whole permission array whenever a request was sent, this made only one permission in the permissions array true and the others false. With this PR that has been adressed by only changing permissions that are in the request header only. This allows unedited permissions to stay false/true until they are changed

How to test

Navigate to the directory run the project and use the update rolePermission on Apollo

cd atlp-devpulse-bn
git checkout ft-impl-updaterole
npm run dev

@kennyg37 kennyg37 changed the title ft implementation role permission update #108 ft implementation role permission update Oct 2, 2024
@kennyg37 kennyg37 changed the title #108 ft implementation role permission update #109 ft implementation role permission update Oct 2, 2024
@Salim-54
Copy link
Collaborator

Salim-54 commented Oct 2, 2024

There are too many unnecessary changes, leave only necessary ones.

@vegetason vegetason self-requested a review October 7, 2024 19:34
Copy link
Contributor

@vegetason vegetason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on this Pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants