Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#89 Throws an error if JWT_SECRET is not set #92

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

mugishaj092
Copy link
Contributor

@mugishaj092 mugishaj092 commented Sep 13, 2024

PR Description

This PR fixes [Issue #89] by adding a check for the JWT_SECRET environment variable during user creation. If JWT_SECRET is missing, an error is thrown to prevent user creation without proper configuration of JWT_SECRET

Description of tasks that were expected to be completed

  • Added a check for the JWT_SECRET environment variable during user creation to prevent user creation if the variable is missing.
  • This ensures proper configuration of JWT_SECRET, enhancing security and consistency.

How has this been tested?

  • Clone repo
  • Checkout branch fix/user-creation-env-check
  • Ensure you set the environment variables as per .env.example.
  • Run npm install, then npm run dev to verify that the app runs successfully and that an error is thrown if JWT_SECRET is missing.

With deployed Link: None

Track PR (issue number & link)

-Issue #89

Screenshots (If appropriate especially on the frontend)

N/A

…m being logged without proper configuration.
@robsdagreat robsdagreat self-requested a review September 14, 2024 19:12
@mugishaj092 mugishaj092 changed the title Throws an error if JWT_SECRET is not set #89 Throws an error if JWT_SECRET is not set Sep 20, 2024
@Salim-54 Salim-54 merged commit 742a065 into develop Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants