Non browser environments fix #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@react-loosely-lazy/manifest", | |||
| "version": "1.0.0", | |||
| "version": "1.1.0", | |||
There was a problem hiding this comment.
We shouldn't bump version in this PR
| return true; | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
Should we keep globalThis !== globalThis.window as value of last return? If something else provides/sets a window key in global we might still falsely believe we are in a browser env.
| * | ||
| * @see https://github.com/jsdom/jsdom/issues/1537 | ||
| */ | ||
| export const isNodeEnvironment = () => { | ||
| return globalThis !== globalThis.window; | ||
| // Some SSR environments remove the window object | ||
| if (typeof window === 'undefined') { |
There was a problem hiding this comment.
Can you use document instead? That's what SSR expects and is used by other libraries like emotion and should cover jsdom
| return true; | ||
| } | ||
|
|
||
| // Official way to check for JSDOM |
There was a problem hiding this comment.
Is that documented somewhere? Also we should treat jsdom as a browser, and return false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8-snapshotwould fail due to an earlysetTimoutaccess.