-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement live internal latency tracker #651
Conversation
Test Results 135 files + 2 135 suites +2 57s ⏱️ +2s Results for commit c395dc4. ± Comparison against base commit 0025f15. This pull request removes 1 and adds 13 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
@@ -13,7 +14,8 @@ data class NadelExecutionInput private constructor( | |||
val variables: Map<String, Any?>, | |||
val extensions: Map<String, Any?>, | |||
val executionId: ExecutionId?, | |||
val nadelExecutionHints: NadelExecutionHints, | |||
val executionHints: NadelExecutionHints, | |||
val latencyTracker: NadelInternalLatencyTracker, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latency tracker is per request & will be passed in by the caller.
// When | ||
assertTrue(stopwatch.elapsed().toNanos() == 0L) | ||
time = 100 | ||
assertTrue(stopwatch.elapsed().toNanos() == 0L) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this elapsed not 100?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I see ignore me
Adds a live internal latency tracker so we can emit internal latency metrics.