Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag EKS cluster security group, route tables, network interfaces and ACLs #445

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

bianchi2
Copy link
Collaborator

@bianchi2 bianchi2 commented Jan 20, 2025

Primary cluster security group is created by AWS, as a result no additional tags are propagated to it.

Also, some AWS resources that aren't created by Terraform lack tags:

  • route tables
  • network ACLs
  • network interfaces

Tagging them in Terraform module is tricky because we can't use for_each for computed recourses. Instead, we gather the list of ids and tag them after the deployment is finished. We need to do that after deployment also because some resources like network interfaces are created when a new node is created, i.e. during scale up.

Checklist

  • I have successful end to end tests run (with & without domain)

@bianchi2 bianchi2 added the e2e label Jan 21, 2025
@bianchi2 bianchi2 changed the title Tag EKS cluster security group Tag EKS cluster security group, route tables, network interfaces and ACLs Jan 21, 2025
@bianchi2 bianchi2 merged commit aaf0bff into main Jan 21, 2025
4 checks passed
@bianchi2 bianchi2 deleted the tag-resources branch January 21, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants