Tag EKS cluster security group, route tables, network interfaces and ACLs #445
+107
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary cluster security group is created by AWS, as a result no additional tags are propagated to it.
Also, some AWS resources that aren't created by Terraform lack tags:
Tagging them in Terraform module is tricky because we can't use for_each for computed recourses. Instead, we gather the list of ids and tag them after the deployment is finished. We need to do that after deployment also because some resources like network interfaces are created when a new node is created, i.e. during scale up.
Checklist