Adapt crowd-bitbucket e2e tests to Bitbucket 9.4.0 #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bianchi2
changed the title
yzha645
reviewed
Dec 10, 2024
| } | ||
| defer resp.Body.Close() | ||
| if resp.StatusCode != http.StatusOK { | ||
| return "", fmt.Errorf("authentication failed: status code %d", resp.StatusCode) |
There was a problem hiding this comment.
Do you think it's worth passing out response body as well? We can then have more detailed message on the actual error.
There was a problem hiding this comment.
Typically 401 or 403 are easy to understand but let's print body as well in case it's a non 200 response.
yzha645
reviewed
Dec 10, 2024
test/e2etest/crowd_test.go
Outdated
| @@ -242,7 +253,7 @@ func crowdTests(t *testing.T, testConfig TestConfig, bitbucketURL string, crowdU | |||
|
|
|||
| // get BITBUCKETSESSIONID to use in the header in subsequent calls | |||
| // even though basic auth works, atl_token is different each time | |||
| bitbucketSessionID := getBitbucketSessionID(bitbucketURL, "admin", testConfig.BitbucketPassword) | |||
| bitbucketSessionID, _ := getBitbucketSessionID(bitbucketURL, "admin", testConfig.BitbucketPassword) | |||
There was a problem hiding this comment.
We're not processing err here even though we have various errors returning from the method?
There was a problem hiding this comment.
🤦 yup, fixed now, added require nil validation instead.
yzha645
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist