Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Escape new lines characters in license strings #347

Closed
wants to merge 1 commit into from

Conversation

bianchi2
Copy link
Collaborator

@bianchi2 bianchi2 commented Dec 5, 2023

This is a rare use case but when it happens, the license becomes a multi line string which makes it invalid and also makes the pre-install job fail (because sed fails).

Checklist

  • I have successful end to end tests run (with & without domain)
  • I have added unit tests (if applicable)
  • I have user documentation (if applicable)

@bianchi2 bianchi2 added the e2e label Dec 5, 2023
@bianchi2 bianchi2 changed the title Escape new lines characters in license strings WIP: Escape new lines characters in license strings Dec 5, 2023
@bianchi2 bianchi2 closed this Dec 5, 2023
@bianchi2 bianchi2 deleted the DCA-2149-fix-pre-install-job branch December 18, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant