Create an optional deployment with a privileged dind container #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanux
approved these changes
Nov 20, 2023
config.tfvars
Outdated
| ################################################################################ | ||
|
|
||
| # Create deployment with a docker-in-docker privileged container. Defaults to false | ||
| # start_test_deployment = true |
There was a problem hiding this comment.
I thought we were setting the commented values to the defaults.
There was a problem hiding this comment.
Good catch. Fixed
variables.tf
Outdated
| # test deployment configuration | ||
|
|
||
| variable "start_test_deployment" { | ||
| description = "Whether to start DCAPT Jmeter and Selenium deployment" |
There was a problem hiding this comment.
Should we say something like "Deploy necessary resources to start DCAPT testing"? So it is potentially flexible in future.
There was a problem hiding this comment.
Yes, sounds good.
|
Should we create DCAPT section under https://atlassian-labs.github.io/data-center-terraform/userguide/configuration/CONFIGURATION/ so we can start documenting DCAPT specifics there? |
|
@nanux added DCAPT Configuration page. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional deployment with docker-in-docker privileged container that can be used to run Jmeter and Selenium tests.
Checklist