Reliability: Flow types for tests (part 4) #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alshdavid
commented
Dec 12, 2024
There was a problem hiding this comment.
We have many tests that are marked as skipped which depend on these functions. The tests were not updated when these functions were removed and they were not detected because type checking was disabled on those files.
I added these stubs to pass the type checker, we will need to correct the skipped tests in the future
There was a problem hiding this comment.
Do we want to keep those skipped tests, or should the be deleted?
There was a problem hiding this comment.
I'm in favour of deleting them but I'd like to leave that for another PR as there are quite a lot of tests to remove. This PR is mainly focused on fixing typing errors
alshdavid
force-pushed
the
alsh/add-flow-to-tests-4
branch
2 times, most recently
from
7f80919 to
ba53c7f
Compare
Changing the underlying type rather than the caller html assert.fail() skipping false positive test test test ci ci image kotlin markdown monorepos parser pnp postcss posthtml reason symbol prop tailwind toml wasm webextension
alshdavid
force-pushed
the
alsh/add-flow-to-tests-4
branch
from
ba53c7f to
16c03a9
Compare
alshdavid
changed the title
alshdavid
force-pushed
the
alsh/add-flow-to-tests-4
branch
from
26e449d to
b386452
Compare
MonicaOlejniczak
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue from here link