Skip to content

fix(identity): label scan search controls - #105

Open
lovewave02 wants to merge 1 commit into
atlas-crew:mainfrom
lovewave02:codex/61-label-scan-search
Open

fix(identity): label scan search controls#105
lovewave02 wants to merge 1 commit into
atlas-crew:mainfrom
lovewave02:codex/61-label-scan-search

Conversation

@lovewave02

Copy link
Copy Markdown

Summary

Adds an explicit accessible name to the scan-review bullet search field and announces visible bullet-count changes to assistive technology.

Why

Issue #61 reports that the scan bullet search field relies on placeholder text and that result-count changes are not announced. Placeholder text is not a durable accessible name, and the count is dynamic as filters change.

Alternatives considered

Using only the existing wrapping <label> was rejected because the issue explicitly asks for confirming/adding a durable label and the current audit evidence calls out the search field. A visible extra label was also unnecessary because the UI already displays "Search bullets"; an explicit aria-label keeps the visual layout unchanged.

Verification

$ PATH=/Users/openclaw/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH npx --yes pnpm@10.32.1 install --frozen-lockfile
Done in 4.8s using pnpm v10.32.1

$ git diff --check

$ PATH=/Users/openclaw/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH npx --yes pnpm@10.32.1 run typecheck
> tsc --noEmit -p tsconfig.app.json

$ PATH=/Users/openclaw/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH npx --yes pnpm@10.32.1 run lint
> eslint .

$ PATH=/Users/openclaw/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH npx --yes pnpm@10.32.1 run build
✓ built in 6.49s

Additional check:

$ PATH=/Users/openclaw/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH npx --yes pnpm@10.32.1 exec vitest run src/test/IdentityPage.test.tsx src/test/IdentityMapEditing.test.tsx
Test Files  1 failed | 1 passed (2)
Tests  21 failed | 252 passed (273)

IdentityMapEditing.test.tsx passed. The failures are in IdentityPage.test.tsx around existing draft/deepen mock invocation expectations; this PR only adds accessibility attributes to the scan search field and visible-count summary.

Risk & blast radius

Low. The change is limited to ScanReviewPane.tsx, does not alter state, filtering, selection, persistence, proxy, Supabase, identity schema, migrations, or dependencies.

Open questions / follow-ups

None.

Closes #61


  • Commits are atomic and bisectable (this repo rebase-merges — they land as-is)
  • CI green: typecheck, lint, test, build, CodeQL
  • If a protected path is touched, it's called out under Risk above

@lovewave02
lovewave02 requested a review from NickCrew as a code owner July 6, 2026 14:42
@github-project-automation github-project-automation Bot moved this to Triage in Facet Jul 6, 2026
@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

@lovewave02 is attempting to deploy a commit to the nickcrew's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

Scan search input has no aria-label

1 participant