fix(identity): label scan search controls - #105
Open
lovewave02 wants to merge 1 commit into
Open
Conversation
|
@lovewave02 is attempting to deploy a commit to the nickcrew's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit accessible name to the scan-review bullet search field and announces visible bullet-count changes to assistive technology.
Why
Issue #61 reports that the scan bullet search field relies on placeholder text and that result-count changes are not announced. Placeholder text is not a durable accessible name, and the count is dynamic as filters change.
Alternatives considered
Using only the existing wrapping
<label>was rejected because the issue explicitly asks for confirming/adding a durable label and the current audit evidence calls out the search field. A visible extra label was also unnecessary because the UI already displays "Search bullets"; an explicitaria-labelkeeps the visual layout unchanged.Verification
Additional check:
IdentityMapEditing.test.tsxpassed. The failures are inIdentityPage.test.tsxaround existing draft/deepen mock invocation expectations; this PR only adds accessibility attributes to the scan search field and visible-count summary.Risk & blast radius
Low. The change is limited to
ScanReviewPane.tsx, does not alter state, filtering, selection, persistence, proxy, Supabase, identity schema, migrations, or dependencies.Open questions / follow-ups
None.
Closes #61