-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add generic oidc provider #25
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # src/runtime/server/lib/oauth/auth0.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # src/runtime/server/lib/oauth/auth0.ts
534b278
to
4081637
Compare
Happy to fix the conflicts and update the readme? No idea what oidc is 😅 |
@atinux "oidc" is OpenID Connect Will update the readme and fix the conflicts. |
4493d90
to
d4b211d
Compare
This looks like a great addition! I have some suggestions/feedback regarding the implementation:
EDIT:
|
@itpropro thank you for the feedback! I will try to incorporate it. |
* main: chore(release): v0.0.15 chore: up deps feat: added aws cognito provider (atinux#36) feat: add auth0 connection parameter to config (atinux#39) fix: replace encoded space characters with regular spaces (atinux#40) chore(release): v0.0.14 chore: update deps feat: added keycloak as oauth provider (atinux#23) chore: test bundler module resolution (atinux#32) chore(release): v0.0.13 chore: rename session from verify to fetch chore(release): v0.0.12 fix: correct arguments for hooks chore(release): v0.0.11 feat: add sessionHooks to extend user sessions
Any progress on this? Have a project that i would love to test the oidc implementation on |
They are still some conflicts and I would like to have the readme updated in order for users to understand how to use it. Happy to take a stab at it? |
Don't know enough auth and openid spec to be able to do that 😢 |
Hi @atinux and @maximilianmikus, it seems no one is taking up the topic again, do you need help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really love to seem this move forward as this is currently our blocker for using this library. We currently vendor a similar change (basically adjusting the Keycloak handler) on a feature branch for a while now and are really happy with it
connection: config.connection || '' | ||
>>>>>>> main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a remainder of a merge conflict here
I am up for that, but why do we need to update the Auth0 provider in this pull request? |
WIP
This PR is based upon #12
This PR adds a generic provider for OIDC. It currently supports the 'code' response type / grant type 'authorization_code' and also optionally 'pkce'. Other response types and grant type combinations are not yet tested, but might in some cases already work.
Feedback welcome.