-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: glee auth v2 #474
feat: glee auth v2 #474
Conversation
glee authentication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments.
Pull Request Test Coverage Report for Build 5799719460Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…leeAuthV2 merge changes
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏼, you can merge it when you are ready.
Merging is blocked on my end... @Souvikns |
/rtm |
🎉 This PR is included in version 0.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@allcontributors please add @oviecodes for code |
I've updated the pull request to add @oviecodes! 🎉 |
@allcontributors please add @oviecodes for code |
I've put up a pull request to add @oviecodes! 🎉 |
Description
This PR continues the discussion on the glee authentication issue #377 , it continues the discussion about glee authentication, from #460 .
Following the idea from @Souvikns to use a separate directory for authentication. Each file in this directory can hold both server and client authentication logic.
Steps to test run authentication
cd examples/anime-http/server
,auth
directory that holds atrendingAnimeServer.ts
file. The file contains some logic you can edit how you like but it must export the same functions as the code abovenpm run dev
to start the server in dev modecd examples/anime-http/server
auth/trendingAnime.js
update accordingly then start the server.Related issue(s)
Resolves #377
@Souvikns @KhudaDad414