Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag for using generator v2 #1513

Merged
merged 10 commits into from
Sep 26, 2024

Conversation

Souvikns
Copy link
Member

@Souvikns Souvikns commented Sep 6, 2024

Description
In this PR I am adding a new Flag to use generator v2+, I am trying to change as little as possible from users original version of CLI. Currently most temapltes are not supporting v2 of generator, so it is better to have flag --use-new-generator, once more templates start supporting v2 of generator we can update the flag.

asyncapi generate fromTemaplate ./spec.yaml @asyncapi/html-template --use-new-generator

Related issue(s)

See also #1388

@Souvikns Souvikns marked this pull request as ready for review September 23, 2024 05:48
check/asyncapi.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 24, 2024

@Shurtu-gal
Copy link
Collaborator

@Souvikns Please merge if ready.

@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty program related label label Sep 24, 2024
@aeworxet
Copy link
Contributor

@asyncapi/bounty_team

Copy link
Member

@peter-rr peter-rr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Souvikns
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit e5806d0 into asyncapi:master Sep 26, 2024
15 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty program related label ready-to-merge released
Projects
Status: Completed
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants