Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: apply design system to new and convert command #1398

Merged
merged 10 commits into from
May 3, 2024
Merged

chore: apply design system to new and convert command #1398

merged 10 commits into from
May 3, 2024

Conversation

Shurtu-gal
Copy link
Collaborator

@Shurtu-gal Shurtu-gal commented Apr 30, 2024 •
edited
Loading

Description

  • This PR aims to implement the new design system for the new command.

Proof of work
image
image
image

Related issue(s)
Fixes #1379
Fixes #1381
Fixes #1385

@Shurtu-gal Shurtu-gal self-assigned this Apr 30, 2024
@Shurtu-gal Shurtu-gal changed the title feat: apply design system to new glee chore: apply design system to new glee Apr 30, 2024
@Shurtu-gal Shurtu-gal changed the title chore: apply design system to new glee chore: apply design system to new command Apr 30, 2024
@Shurtu-gal
Copy link
Collaborator Author

cc: @Amzani

@Shurtu-gal
Copy link
Collaborator Author

Proof for convert command:
image

@Shurtu-gal Shurtu-gal changed the title chore: apply design system to new command chore: apply design system to new and convert command May 1, 2024
@Shurtu-gal
Copy link
Collaborator Author

Proof for validate command.
image

KhudaDad414
KhudaDad414 reviewed May 1, 2024
View reviewed changes
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. left some suggestions.

KhudaDad414
KhudaDad414 reviewed May 1, 2024
View reviewed changes
src/commands/convert.ts Outdated Show resolved Hide resolved
KhudaDad414
KhudaDad414 reviewed May 1, 2024
View reviewed changes
src/commands/convert.ts Outdated Show resolved Hide resolved
KhudaDad414
KhudaDad414 reviewed May 1, 2024
View reviewed changes
src/commands/convert.ts Outdated Show resolved Hide resolved
@Shurtu-gal
Copy link
Collaborator Author

@KhudaDad414 I have applied the suggestions.

KhudaDad414
KhudaDad414 approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shurtu-gal
Copy link
Collaborator Author

/update

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Shurtu-gal
Copy link
Collaborator Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 2b75821 into asyncapi:master May 3, 2024
11 checks passed
@Shurtu-gal Shurtu-gal deleted the design-system branch May 3, 2024 07:48
peter-rr
peter-rr reviewed May 3, 2024
View reviewed changes
Copy link
Member

@peter-rr peter-rr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM 🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aeworxet aeworxet mentioned this pull request May 7, 2024
Closed
5 tasks
@aeworxet aeworxet added the bounty AsyncAPI Bounty program related label label May 7, 2024
@ibishal ibishal mentioned this pull request May 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-rr peter-rr peter-rr left review comments

@Souvikns Souvikns Souvikns approved these changes

@KhudaDad414 KhudaDad414 KhudaDad414 approved these changes

@Amzani Amzani Awaiting requested review from Amzani Amzani is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees

@Shurtu-gal Shurtu-gal

Labels
bounty AsyncAPI Bounty program related label ready-to-merge released
Projects
Bounty Program
Status: Completed
CLI - Kanban
Status: Done
Milestone
No milestone
6 participants
@Shurtu-gal @asyncapi-bot @KhudaDad414 @Souvikns @peter-rr @aeworxet