-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added consistent styling for buttons and tags #1099
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Hargun Kaur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hargunkaur286 i don't think you should apply the changes to the messageExample.tsx file 🤔
Signed-off-by: Hargun Kaur <[email protected]>
Signed-off-by: Hargun Kaur <[email protected]>
Signed-off-by: Hargun Kaur <[email protected]>
@AceTheCreator @catosaurusrex2003 Thank you for the feedback. I have removed the changes from messageExample.tsx file |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM too 🚀 |
Description
This PR is related to the issue with inconsistent styling. According to the issue, "WCAG 2.0 guideline 3.2.4 Consistent Identification states "Components that have the same functionality within a set of Web pages are identified consistently".
For example:
If we move to async-react website,
We will notice that there are multiple elements with a solid color background, but only some of them are a button.
Changes proposed in this pull request:
To resolve this, the ask in the issue was:
In this PR, changes have been made in 4 files:
In "library/src/components/Schema.tsx" file:
Addresses the tags "Default values", "const", "Allowed values", "Example values".
BEFORE:
AFTER:
In "library/src/containers/Messages/Message.tsx" file
Addresses tags of "Correlation Id" and "Message Id"
BEFORE:
AFTER:
In "library/src/containers/Messages/MessageExample.tsx" file
Addresses the example labels
BEFORE:
AFTER:
In "library/src/containers/Operations/Operation.tsx" file
BEFORE:
AFTER:
Related issue(s)
Resolves #960