Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed the Navigation tab functionality #1046

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

ItshMoh
Copy link
Contributor

@ItshMoh ItshMoh commented Sep 16, 2024

Description
Fixed the navigation problem in NavBar.

Related issue(s)
fixes: #1008
Screencast from 16-09-24 09_25_04 PM IST.webm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ItshMoh ItshMoh changed the title Changed the Navigation tab functionality fix: changed the Navigation tab functionality Sep 16, 2024
@ItshMoh
Copy link
Contributor Author

ItshMoh commented Sep 18, 2024

@derberg @AceTheCreator can you review my pr?

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@AceTheCreator
Copy link
Member

@ItshMoh, can you kindly update your branch?

@ItshMoh
Copy link
Contributor Author

ItshMoh commented Oct 3, 2024

@ItshMoh, can you kindly update your branch?

@AceTheCreator Updated the branch.

Copy link

sonarcloud bot commented Oct 7, 2024

@AceTheCreator
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit a541aba into asyncapi:master Oct 7, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 bug : navigation tab is not working properly
3 participants