Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure hidden section not appearing in sidebar #1038

Merged
merged 10 commits into from
Aug 22, 2024
Merged

fix: make sure hidden section not appearing in sidebar #1038

Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9a91a0c
.
AceTheCreator Nov 6, 2023
f2703af
Merge branch 'master' of https://github.com/AceTheCreator/asyncapi-react
AceTheCreator Nov 15, 2023
cac452a
Merge branch 'master' of https://github.com/AceTheCreator/asyncapi-react
AceTheCreator Nov 28, 2023
6e6e79c
Merge branches 'master' and 'master' of https://github.com/AceTheCrea…
AceTheCreator Apr 23, 2024
14620a8
fix:nklf
AceTheCreator Aug 12, 2024
17d2ae8
fixed hidden section still appearing in sidebar
AceTheCreator Aug 12, 2024
d2cf282
Delete web-component/package-lock.json
AceTheCreator Aug 12, 2024
b885700
Delete playground/package-lock.json
AceTheCreator Aug 12, 2024
fc007b2
Update Sidebar.tsx
AceTheCreator Aug 22, 2024
eba9b34
Merge branch 'master' into fix-sidebar
AceTheCreator Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions library/src/containers/Sidebar/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const SidebarContext = React.createContext<{
export const Sidebar: React.FunctionComponent = () => {
const [showSidebar, setShowSidebar] = useState(false);
const asyncapi = useSpec();
const config = useConfig();

const info = asyncapi.info();
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
Expand All @@ -23,6 +24,9 @@ export const Sidebar: React.FunctionComponent = () => {
const schemas = components?.schemas().all();
const hasOperations = asyncapi.operations().length > 0;

const showMessages = config.show?.messages;
const showSchemas = config.show?.schemas;

const messagesList = messages?.length > 0 && (
<li className="mb-3 mt-9">
<a
Expand Down Expand Up @@ -75,6 +79,7 @@ export const Sidebar: React.FunctionComponent = () => {

const operationList = hasOperations && (
<>
<h1>Testing</h1>
derberg marked this conversation as resolved.
Show resolved Hide resolved
<li className="mb-3 mt-9">
<a
className="text-xs uppercase text-gray-700 mt-10 mb-4 font-thin hover:text-gray-900"
Expand All @@ -85,8 +90,8 @@ export const Sidebar: React.FunctionComponent = () => {
</a>
<OperationsList />
</li>
{messagesList}
{schemasList}
{showMessages && messagesList}
{showSchemas && schemasList}
</>
);

Expand Down
Loading