Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: development server not detecting local changes #1006

Merged
merged 4 commits into from
Jun 11, 2024
Merged

fix: development server not detecting local changes #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ce3809
Fix playground to detect local changes
May 21, 2024
a620367
Address review comments
May 21, 2024
72b572e
Merge branch 'master' into fix/playground-npm-workspaces
derberg Jun 11, 2024
970334c
Merge branch 'master' into fix/playground-npm-workspaces
derberg Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/release-wc-and-playground.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,6 @@ jobs:
node-version: "${{ steps.lockversion.outputs.version }}"
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
- name: Use latest version of react component in the playground
run: VERSION=${{github.event.release.tag_name}} npm run install:reactcomp
working-directory: ./playground
- name: Install dependencies
run: npm install
- name: Build
Expand Down
34 changes: 1 addition & 33 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,9 @@
"prepublishOnly": "npm run build",
"gen-readme-toc": "markdown-toc -i README.md",
"generate:assets": "npm run gen-readme-toc",
"bump:playground:version": "cd playground && npm --no-git-tag-version --allow-same-version version $VERSION",
"bump:webcomp:version": "cd web-component && npm --no-git-tag-version --allow-same-version version $VERSION",
"bump:lib:version": "cd library && npm --no-git-tag-version --allow-same-version version $VERSION",
"bump:version": "npm run bump:lib:version && npm run bump:webcomp:version && npm run bump:playground:version && npm run install:reactcomp:webcomponent && npm run install:reactcomp:playground",
derberg marked this conversation as resolved.
Show resolved Hide resolved
"install:reactcomp:playground": "cd playground && npm run install:reactcomp",
"bump:version": "npm run bump:lib:version && npm run bump:webcomp:version && npm run install:reactcomp:webcomponent",
"install:reactcomp:webcomponent": "cd web-component && npm run install:reactcomp",
"get:name": "cd library && npm run get:name",
"get:version": "cd library && npm run get:version"
Expand Down
13 changes: 0 additions & 13 deletions playground/bump-react-comp.sh
View file
Open in desktop

This file was deleted.

6 changes: 2 additions & 4 deletions playground/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
{
"name": "playground",
"version": "2.0.0",
"private": true,
"scripts": {
"build": "next build && touch out/.nojekyll",
"start": "next dev",
"install:reactcomp": "chmod +x ./bump-react-comp.sh && ./bump-react-comp.sh"
"start": "next dev"
},
"dependencies": {
"@asyncapi/react-component": "^1.4.10",
"@asyncapi/react-component": "file:../library",
"@codemirror/lang-yaml": "^6.0.0",
"@uiw/codemirror-theme-material": "^4.21.24",
"@uiw/react-codemirror": "^4.21.24",
Expand Down
Loading