Skip to content

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Nov 16, 2019

I think the pub $vis in stream also are style inconsisitent.
Because like new fn is only used by super module, pub(crate) / pub(super) / pub are all no different.

@yjhmelody
Copy link
Contributor Author

yjhmelody commented Nov 16, 2019

@taiki-e why use pub(crate) rather than pub(super)?

@yjhmelody yjhmelody force-pushed the fix-stream-code-style branch from 1854386 to 223fcc3 Compare November 16, 2019 16:36
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice bit of cleanup. Thanks heaps!

@yoshuawuyts yoshuawuyts added this to the 1.1.0 milestone Nov 20, 2019
@yoshuawuyts yoshuawuyts merged commit d1189f9 into async-rs:master Nov 20, 2019
@yjhmelody yjhmelody deleted the fix-stream-code-style branch November 22, 2019 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants