Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove astropy_init #263

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Feb 14, 2025

This removes _astropy_init.py. It is leftover from a no longer maintained project template:
https://github.com/astropy/package-template
and contains:

  • code to provide asdf_astropy.__version__ (moved to __init__.py in this PR)
  • code to (attempt to use) the astropy TestRunner vai asdf_astropy.test()

The TestRunner will soon be deprecated and attempting to use it on main fails with:

PytestAssertRewriteWarning: Module already imported so cannot be rewritten: asdf

Our documentation already describes ways to run the tests (none of which use asdf_astropy.test):

Testing

Since asdf_astropy.test is not working and not documented this PR removes it.

Closes #262

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (7adb9a5) to head (bcd5cf1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          62       62           
  Lines        2208     2209    +1     
=======================================
+ Hits         2197     2198    +1     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review February 14, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notice: You are using astropy TestRunner that will be deprecated
1 participant