Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RT9 packaging issue - v1.1.1 #54

Merged
merged 10 commits into from
Oct 13, 2023
Merged

fix RT9 packaging issue - v1.1.1 #54

merged 10 commits into from
Oct 13, 2023

Conversation

fritz-astronomer
Copy link
Contributor

@fritz-astronomer fritz-astronomer commented Oct 11, 2023

  • starship 1.1.1
  • issue fixed: added get_provider_info, which was causing failures with RT9. Also needed to rename the package from astronomer -> astronomer_starship to prevent some naming collisions.
  • issue fixed: Accepted request headers are different and caused starship requests to fail in Astro
  • improvement: added test coverage for both Hosted and Hybrid APIs
  • issue fixed: Fixed an issue with a newer version of SQLAlchemy seeming to have broken the DAG History migration due to a deprecation
  • issue fixed: test connection was disabled by default in Astro/Airflow in RT9. We should turn it back on, IMO, but that's a product call
  • improvement: Removed pytest-xdist which runs pytests in parallel, instead run the really long tests all in parallel in one test

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (24a2829) 41.74% compared to head (98c9b88) 41.56%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   41.74%   41.56%   -0.18%     
==========================================
  Files          15       16       +1     
  Lines        1114     1150      +36     
==========================================
+ Hits          465      478      +13     
- Misses        649      672      +23     
Files Coverage Δ
astronomer_starship/aeroscope/operators.py 36.58% <100.00%> (ø)
astronomer_starship/aeroscope/plugins/__init__.py 60.34% <100.00%> (ø)
astronomer_starship/aeroscope/util.py 96.29% <ø> (ø)
astronomer_starship/starship/main.py 42.39% <100.00%> (ø)
...ronomer_starship/starship/services/astro_client.py 27.83% <ø> (ø)
...tarship/starship/services/remote_airflow_client.py 35.61% <100.00%> (ø)
...stronomer_starship/starship/variables/operators.py 47.82% <ø> (ø)
astronomer_starship/starship/operators.py 30.20% <50.00%> (ø)
astronomer_starship/__init__.py 80.00% <80.00%> (ø)
...mer/starship/services/local_airflow_client_test.py 37.66% <81.81%> (+2.59%) ⬆️
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fritz-astronomer fritz-astronomer force-pushed the compat branch 4 times, most recently from 2479669 to 21b5e51 Compare October 12, 2023 19:35
@fritz-astronomer fritz-astronomer marked this pull request as ready for review October 13, 2023 18:59
@fritz-astronomer fritz-astronomer changed the title fix RT9 packaging issue fix RT9 packaging issue - v1.1.1 Oct 13, 2023
@fritz-astronomer fritz-astronomer merged commit 591841d into main Oct 13, 2023
6 checks passed
@fritz-astronomer fritz-astronomer deleted the compat branch October 13, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants