Add deprecation warning in core provider #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
requested review from
phanikumv,
pankajkoti,
Lee-W,
sunank200,
utkarsharma2 and
vatsrahul1001
as code owners
Lee-W
approved these changes
Jan 22, 2024
|
There are some test fails, but I guess they can be resolved by rebasing 🤔 |
pankajastro
force-pushed
the
core_deprecation
branch
from
b814014 to
702f7c9
Compare
|
mypy error is not related to this PR, we should fix it in a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just added a deprecation warning in the core provider to warn users about removal and encourage them to use the upcoming OSS sensor
closes: #1413